Fec-cms: Visual review and refinement of Tips for Treasurers

[noahmanger]

Before we release the Tips for Treasurers, 18F and FEC need to review and address any refinement issues.

To view them on staging, go here.

Tasks:

• [x] @jenniferthibault review
• [x] Fix credit to come from Information Division
• [x] Assign to someone at FEC to review

[dorothyyeager]

Hi just was looking at Tips for Treasurers on the beta site. I noticed an issue so I hope this is the right thread for it. It's being credited to the Press Office but it's actually Information Division (Greg and me) that puts it out, so that should be changed. Any questions FEC-wise about the tips, am happy to answer, just let me know. Thanks!

[noahmanger]

Thanks @dorothyyeager ! Adding it to the list.

[jenniferthibault]

A couple quick additional things that look like they can be solved programmatically:

• [ ] Add paragraph styling to main body content so that the content is scraped into a <p> tag. This will fix:
• the font size in the page template, which is currently too small

• the excerpt in the feed layout, which is currently escaping the container it's meant to live in
  

• [ ] To be consistent with other sections, the Read next field should say "More Tips for Treasurers"
  

For next steps, @noahmanger should we fix these before assigning an FEC team member to take a final review? Or assign someone with these caveats listed? They aren't too hard to look beyond, but they do add interference for now that might make smaller details easier to overlook.

[noahmanger]

Awesome. Let's ask them to review now, since we won't be able to fix those until there's new code in production.

[jenniferthibault]

👋 @dorothyyeager would you like to take another review of the Tips for Treasurers pages with the changes above in mind?

You can see them on staging here: https://fec-stage-proxy.18f.gov/updates/?update_type=tips-for-treasurers

[dorothyyeager]

thanks @jenniferthibault @noahmanger will take a look through it!

[dorothyyeager]

Hi - have some comments I'll forward to you via email but overall looks good - just needs some tweaking here and there. Thanks!

[AmyKort]

Thank you, Dorothy! It's such a pleasure to work with you!!

[jenniferthibault]

Bringing in the complete list of fix criteria here:

• [x] From: field should list Information Division instead of Press Office
• [x] Remove periods from article titles
• [x] Add paragraph styling to main body content so that the content is scraped into a

  tag. From above

• [x] On article page, document tag should say Tips for treasurers instead of Weekly digest
• [x] Read next: first item should list another Tip document (maybe the most recent one published before this)
• [x] The Read next field should say "More Tips for Treasurers" in the link to the full list From above

@noahmanger this gives a complete list to work off of for https://github.com/18F/fec-cms/pull/803

[noahmanger]

Ok! Made all those changes.

[dorothyyeager]

Thanks! Looks good!

[dorothyyeager]

Follow-up question - should I go ahead and start entering future tips now (like I'm doing with Record articles)?

[noahmanger]

@dorothyyeager we're going to need to run the scraper again for the new changes to take affect, so no need to add future ones just yet, as they'll get imported. Once we run that for the last time, then you can start adding new ones.

[noahmanger]

Resolved by #803 . Now we just need to re-import the tips on production and enable them via the feature flag and they'll be good to go.