Fastify: package-lock.json missing

Created on 11 Jan 2019 · 3Comments · Source: fastify/fastify

💬 Questions and Help

I'm wondering why you do not use package-lock.json ? Which is against npm recommendation.

Also if you don't want to commit this file, why is it not filtered in the .gitignore. This would avoid PRs that add this file (I saw some comments about this in the code reviews).

question

Source

PacoDu

Most helpful comment

https://github.com/sindresorhus/ama/issues/479#issuecomment-310661514 sum up my point of view.
I don't know what other members of this community thinks, so we might want to re-evaluate our decision in this regard.

We also support both yarn and npm, and it means that the respective lockfiles would likely conflict. Overall it's probably a good idea not to commit one.

Note that https://github.com/fastify/fastify/blob/master/.gitignore#L62 excludes them already. Somebody would have to forcefully add them.

mcollina on 11 Jan 2019

👍2

All 3 comments

We also support both yarn and npm, and it means that the respective lockfiles would likely conflict. Overall it's probably a good idea not to commit one.

Note that https://github.com/fastify/fastify/blob/master/.gitignore#L62 excludes them already. Somebody would have to forcefully add them.

mcollina on 11 Jan 2019

👍2

Thanks ! I see your point know based on sindresorhus' comment.

Didn't noticed this one >.< https://github.com/fastify/fastify/blob/master/.gitignore#L62, I originally wrote this in fastify-gql and decided to move this issue here.

PacoDu on 11 Jan 2019

Feel free to send a PR to ignore it in any of my modules.

mcollina on 11 Jan 2019

Was this page helpful?

0 / 5 - 0 ratings