Fasthub: Add a button to subscribe/unsubscribe

[zvirja]

FastHub Version: 4.2.0
Android Version: 7.0 (SDK: 24)
Device Information:

• Manufacturer: Xiaomi
• Brand: Xiaomi

- Model: Mi 5

Add a feature to subscribe/unsubscribe from issue/PR notifications. This is really minor feature, as I need this rarely and could open issue in the browser for this purpose. :wink:

[zvirja]

Okay :worried:

[k0shk0sh]

it's not that I don't want to implement, there is no api for it

[zvirja]

Isn't this API exactly about this feature? I could miss something, but at the first glance it looks like the right API.. :sweat:

[k0shk0sh]

where is the thread ID, that's the problem lol

[zvirja]

Briefly Googled and indeed it seems to be the issue :unamused:

[dedepete]

I don't think this research can help you, but I have just found thread_id in the page's source code.

[yakov116]

@dedepete but it is not in the api response

[dedepete]

@yakov116 there should be a way to get it via api.

[yakov116]

@dedepete should be... that is a word github does not have in their language book :stuck_out_tongue:

We have learnt the hard way that if they don't have it don't expect it anytime soon.

[Phoenix09]

but the API does provide it.

https://api.github.com/repos/k0shk0sh/FastHub/issues/974
notice the id value?

which funnily enough, matches the thread_id input for the form on the site, as shown in @dedepete's comment.

so clearly it's a case of "don't want to"

[k0shk0sh]

they added it lately then . thanks

[zvirja]

Should we re-open this one?

[k0shk0sh]

the good new is, implementing this won't take even 10 minutes because I already have the code for that, a matter of changing API call :)

[k0shk0sh]

well well,

D: <-- 403 Forbidden https://api.github.com/notifications/threads/264319772/subscription
{"message":"Must have admin rights to Repository.","documentation_url":"https://developer.github.com/v3/activity/notifications/#set-a-thread-subscription"}

I hate github API!!!!

[jancborchardt]

It's not really a solution, but in Octodroid when you go back from an issue to the Notifications list, that issue is shown greyed out. From the notifications you can seemingly unsubscribe (whereas from inside the issue you can not).

[k0shk0sh]

@jancborchardt I didn't get your point in here, but from the notification list, the notificationId is provided, however in the issue isn't.

This wont be fixed until Github decide to change their API which four months ago they said that they will work on.