Fasthub: Closed issues are not displayed

[zvirja]

FastHub Version: 4.2.0
Android Version: 7.0 (SDK: 24)
Device Information:

• Manufacturer: Xiaomi
• Brand: Xiaomi

- Model: Mi 5

Steps to reproduce:

1. Open this repo: AutoFixture
2. Navigate to issues. You will see 373 closed.
3. Navigate to the Closed tab.

As result you'll see only 2 issues. If I use search, everything is displayed fine.

Thanks :flushed:

[k0shk0sh]

I guess I know what's going on, its due to the first pagination is fulled with PRs and only two issues are in the first page, therefore pagination wont work lol

[k0shk0sh]

:thanksgithubapi:

[zvirja]

Wow, so quick reply and guess - it's impressive :star2:

[k0shk0sh]

it happened i was in the tram :p

GitHub API is sooo shitty that it returns PRs with the Issues API and therefore I have to filter them myself. so that is what's happening.

[zvirja]

@k0shk0sh BTW, just noticed that this issue wasn't fixed completely. Open the repository from the initial scenario and you will be unable to see all the closed issues. App version: 4.3.0.

[zvirja]

@k0shk0sh Unfortunately the issue still persists and I'm unable to see all the closed issues. The link to the repository is still the same :disappointed:

[k0shk0sh]

But the question is, it was fixed that time, why would it break this time? 🤔

[zvirja]

I don't know - probably it depends on number of opened PRs/Issues..

[k0shk0sh]

@zvirja nope, not really, I will check for the number of issues are actually loaded in the list so if it has never loaded.

https://github.com/k0shk0sh/FastHub/blob/11b22a0914c91ad10be631864f52048f31e71674/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/RepoIssuesPresenter.java#L84-L84

[k0shk0sh]

Found the issue and fixed it :)

[zvirja]

@k0shk0sh Wow, that's great! Thank you a lot for making this app better 🎖