Fasthub: Share URL is using generic text/* type instead of text/plain

Created on 27 Jun 2017  路  7Comments  路  Source: k0shk0sh/FastHub

In shareUrl@HelperActivity the save intent is using the generic MIME Type text/* instead of indicating text/plain.

It doesn't have any major effect, though it's cleaner and the type should indicate what you are sharing.
(In addition, it's possible to add the title of the link that is shared)

Medium Accepted Enhancement

Most helpful comment

I'll send a PR later today.
Thanks!

All 7 comments

Hey thanks for reporting this, wouldn't specifying the file as text will eliminate some apps from appearing? For example if some app listening to .java and the file you shared is a Java a file would the app ever be able to receive the intent?

_Sent from my Samsung SM-G950F using FastHub Debug_

Hey, true it will eliminate some apps (I haven't thought about it).
Maybe I miss something, but you are not sharing the URL itself and not the java file, will an app that listens to .java will know how to handle it? wouldn't it be as EXTRA_STREAM as a file?

@talhacohen yep, you're right, only urls that I'm sharing, would you like to submit a PR with the changes? Or should I proceed with changing it?

_Sent from my Samsung SM-G950F using FastHub Debug_

I'll send a PR later today.
Thanks!

@talhacohen alright thanks :)

_Sent from my Samsung SM-G950F using FastHub Debug_

@k0shk0sh does this have to do with #489?

_Sent from my HTC Nexus 9 using FastHub_

@yakov116 nope, unrelated.

_Sent from my Samsung SM-G950F using FastHub Debug_

Was this page helpful?
0 / 5 - 0 ratings

Related issues

szechyjs picture szechyjs  路  3Comments

alexejk picture alexejk  路  3Comments

dikiaap picture dikiaap  路  4Comments

nixel2007 picture nixel2007  路  3Comments

camillo777 picture camillo777  路  3Comments