Fasthub: Add ability review changes in pull requests

Created on 16 May 2017  路  6Comments  路  Source: k0shk0sh/FastHub

  • FastHub Version: 2.1.0
  • Android Version: 6.0.1
  • Phone Model: Samsung Galaxy S6

I couldn't find a way to approve / comment on / request changes for PRs. It'd be nice to have that possibility in the app.

High Completed Enhancement Feature Request

All 6 comments

@sschuberth thanks for reporting, review prs isn't correctly implemented yet there is an open issue for it in #375 #429 , next version you'll be able to reply to reviews, interact to them via emojies and maybe after that there will a way to review the PRs.

Thanks for the info. But actually, I believe none of the linked issues is a strict duplicate of this issue:

  • #323 is about making file comments, which is something you can do without starting a review.
  • #375 is a duplicate of #323 (according to the author).
  • #429 is about adding reviewers to PRs.

All of these are different from being able to do what is possible from this dialog in the web UI:

2017-05-16_141040

@sschuberth Oops, please forgive my misunderstanding. I thought they are somehow related. I'll try and do that, but can't promise you anytime soon, but its in my list.

this should have been closed few days ago :D . I hope I didn't close another issue instead.

Thanks @k0shk0sh. Mind explaining where the feature to add review summary comments and approve reviews is hidden? I was unable to find it in the UI so far.

@sschuberth its in the nightly builds.

Will be in the next public release too.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

szechyjs picture szechyjs  路  3Comments

nixel2007 picture nixel2007  路  3Comments

tom-ando picture tom-ando  路  3Comments

kutsan picture kutsan  路  4Comments

yochananmarqos picture yochananmarqos  路  3Comments