Fasthub: [Enhancement] Hide "read all" button in all notifications tab if all from repository are read

Created on 1 May 2017  路  4Comments  路  Source: k0shk0sh/FastHub

App Version: 2.0.0

OS Version: 25

Model: Huawei-Nexus 6P

The clear all button (three lines) in the all notifications tab can be hidden if all items of a repository are actually read:
Screenshot

Medium Completed Enhancement

Most helpful comment

@k0shk0sh I would! Sadly I'm pretty busy with my final exams atm. I already took a quick look at the Notification (header) adapters and viewholders, but I didn't see yet how and where the clear button is handled.

Btw, your build.gradle and project structure are really amazing, e.g. I didn't know you could put resources in custom subfolders. :+1:

All 4 comments

Wanna take over this? 馃槢

@k0shk0sh I would! Sadly I'm pretty busy with my final exams atm. I already took a quick look at the Notification (header) adapters and viewholders, but I didn't see yet how and where the clear button is handled.

Btw, your build.gradle and project structure are really amazing, e.g. I didn't know you could put resources in custom subfolders. :+1:

@Maxr1998 it will be handled in AllNotificationsFragment & AllNotificationsPresenter we could add a flag to the group model in header row to hide the icon.
I'll look at it later, good luck with your exam.

This issue has been fixed in commit 749cedd.

Was this page helpful?
0 / 5 - 0 ratings