Fasthub: [Feature request] Ability to see/make PR file comments

Created on 15 Apr 2017  路  7Comments  路  Source: k0shk0sh/FastHub

  • FastHub Version: 1.8.1
  • Android Version: 7.1.1
  • Phone Model: OnePlus One

Currently, it's impossible to see review comments on files in PRs. You can look at this PR as an example.

High Completed Feature Request Maintenance

Most helpful comment

+1

All 7 comments

+1

This has been implemented and shall out today however replying isn't currently available also creating, viewing will be there

@k0shk0sh does this story cover adding an initial comment on a line, or should a separate issue be created for that?

@eygraber thanks for reminding me of this lol, there is an open issue for what you asked for :) hopefully soon

_Sent from my Htc m8 using FastHub_

@k0shk0sh which issue is that? The ability to create review/commit comments on code is basically the only thing keeping me from using FastHub as my daily driver.

@eygraber this related to displaying pr reviews created from browser plus interacting with them, the possibility to add PR changes isn't available yet, you could add commit comments but not yet on line commments as I couldn't find how to do that with the possibility of calling each file separately and get it's line number and stuff like that which going to be complicated, however its on my list of todo and hopefully start this week. I got the overall idea and hopefully it works

_Sent from my Htc m8 using FastHub_

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Thaodan picture Thaodan  路  3Comments

bramborman picture bramborman  路  3Comments

wimstefan picture wimstefan  路  3Comments

lil5 picture lil5  路  3Comments

shaboigan picture shaboigan  路  3Comments