Fasthub: After refresh unable to remove emojis

[eygraber]

I can add an emoji multiple times on a comment, but refreshing the screen only shows it added once.

[kutsan]

Thanks. It's a known bug. Will be fixed.

[k0shk0sh]

I'm not even sure if I'm ever to fix it, since I'm not planning decouple the recyclerview with an api call for each comment.

[eygraber]

I haven't looked at source much (I plan to, and make contributions, but work has been crazy 😁 ), but is there a reason not to do that, or you just don't want to re-architecture it?

[k0shk0sh]

@eygraber too much to do in the row item level reactions api is still in preview and is sucks

[eygraber]

@k0shk0sh now it limits me to adding an emoji twice 😁 (i.e. I can click an emoji twice and it'll show 2 in the counter, but if I refresh there's 1).

[k0shk0sh]

@eygraber I guess I'll need to add another hack if that's the case lol

[nyuszika7h]

I can still add reactions an unlimited number of times on 2.1.0.

[yakov116]

@nyuszika7h but upon refresh its gone no?

[nyuszika7h]

Nope, I have to press the back button and go back to the issue for it to be gone.

Normally you can also take away your reaction by clicking on it again, so this is pretty confusing.

[yakov116]

@nyuszika7h in other words we have a bug. Unable to remove an emoji!

[k0shk0sh]

In user point of view its a bug, but in terms of development & api limitations it's not,

1. There is no way I could tell if user liked the comment but loading all the users for reactions & loop through them to check that.
2. Fasthub taking care of your first like, wait a second & you shall be able to unlike it.
3. I have contacted GitHub about this, they said they considering adding proper api for this, but that was two months ago.
4. Nothing much I could do here tbh.

_Sent from my Htc m8 using FastHub_

[nyuszika7h]

I see. But at least if the user has already reacted within the current session in the app, that can be cached locally. And for the other cases, can't you just re-request the counts after the user reacts? Or is that not possible, and you have to iterate over every user and sum the counts? I can't be bothered to look at the API docs right now since I'm on mobile.

(Also, the issue should be renamed to "reactions" rather than "emojis", because sure, they are all emojis, but that term doesn't solely refer to the reactions.)

[k0shk0sh]

@nyuszika7h I'm doing that, but once you click it multiple times at once, I can't do much, maybe a progress to hang you there until request is finished or disable that item until it's finished.
Please do open another issue instead.

_Sent from my Htc m8 using FastHub_