Fast: PeerDependency of Lodash is missing in the foundations

Created on 31 Aug 2020  路  3Comments  路  Source: microsoft/fast

Lodash is declared as peer dependency inside components package.
But it's used inside foundations and the declaration of the dependency is missing.

it's imported from here https://github.com/microsoft/fast/blob/0530a4230946d2aee39861001f3deea3b8816038/packages/web-components/fast-foundation/src/menu/menu.ts#L2

but not present in the package.json
https://github.com/microsoft/fast/blob/0530a4230946d2aee39861001f3deea3b8816038/packages/web-components/fast-foundation/package.json#L92

fast-foundation bug good-first-issue request

All 3 comments

I opened this PR to take care of this!

@chrisdholt we can close this issue 馃憤

closed by #4298

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nicholasrice picture nicholasrice  路  5Comments

MarcSkovMadsen picture MarcSkovMadsen  路  6Comments

eljefe223 picture eljefe223  路  6Comments

MarcSkovMadsen picture MarcSkovMadsen  路  4Comments

bheston picture bheston  路  3Comments