What do you think about adding the rspec suite test in the Faker project?
We should allow contributors to choose whether they want to use Rspec or Minitest.
I noticed that many developers are more comfortable with rspec, so why shouldn't we have both test frameworks in the same project?
Since we have Coveralls, we can track in which part of the code we're missing tests/specs.
vbrazo
All 3 comments
@vbrazo As a newbie open-source dev, I can say that having options in how you test can lower the entry barrier for other newbies. Testing is important, so making it accessible to more people is equally so?
Cheers!
aamarill
on 19 May 2018
I don’t love the idea of having two testing frameworks in the same project. I can see it being a source of confusion for new contributors, who might wonder, “which one do I use?”
It seems to me that’s it’s easy enough for someone to look at the tests that are already in place as an example of how to write non-especially tests.
stympy
on 20 May 2018
Thank you @stympy for the wonderful insight. 😄
aamarill
on 20 May 2018
Related issues
CJAdeszko
·
6Comments
huyderman
·
4Comments
supiash1
·
5Comments
lassiter
·
3Comments
ggrillone
·
6Comments
Most helpful comment
I don’t love the idea of having two testing frameworks in the same project. I can see it being a source of confusion for new contributors, who might wonder, “which one do I use?”
It seems to me that’s it’s easy enough for someone to look at the tests that are already in place as an example of how to write non-especially tests.