Facebook-ios-sdk: Crash in FBSDKRestrictiveDataFilterManager.m line 80

[clayjonezie]

Checklist

• [X] I've updated to the latest released version of the SDK (we are experiencing this on an older version from previous builds, FBSDK 6.5.0. I do not know if FBSDK 6.5.2 resolves the issue.)
• [X] I've searched for existing GitHub issues
• [X] I've looked for existing answers on Stack Overflow, the Facebook Developer Community Forum and the Facebook Developers Group
• [X] I've read the Code of Conduct
• [x] This issue is not security related and can safely be disclosed publicly on GitHub

Environment

Describe your dev environment here, giving as many details as possible. If you have them, make sure to include:

• Xcode Version: 11.4.1
• FBSDK 6.5.0 (at time of build)

Goals

What do you want to achieve?

We are using FBSDK in our app as an authentication option

Expected Results

What do you expect to happen?

I would like FBSDK to not crash

Actual Results

What actually happened? Can you provide a stack trace?

FBSDK is crashing at a large volume.

Steps to Reproduce

What are the steps necessary to reproduce this issue?

I'm not sure yet, this is happening intermittently (but at a high volume) in the field.

Code Samples & Details

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x1a5c2896c __exceptionPreprocess
1  libobjc.A.dylib                0x1a5941028 objc_exception_throw
2  CoreFoundation                 0x1a5b26dcc -[NSOrderedSet initWithSet:copyItems:]
3  CoreFoundation                 0x1a5c2d048 ___forwarding___
4  CoreFoundation                 0x1a5c2f3a0 _CF_forwarding_prep_0
5  FBSDKCoreKit                   0x1039830cc +[FBSDKRestrictiveDataFilterManager updateFilters:] + 80 (FBSDKRestrictiveDataFilterManager.m:80)
6  FBSDKCoreKit                   0x103985f34 +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 240 (FBSDKServerConfigurationManager.m:240)
7  FBSDKCoreKit                   0x103985750 __78+[FBSDKServerConfigurationManager loadServerConfigurationWithCompletionBlock:]_block_invoke + 161 (FBSDKServerConfigurationManager.m:161)
8  FBSDKCoreKit                   0x103969c5c -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41)
9  FBSDKCoreKit                   0x103967534 __82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 806 (FBSDKGraphRequestConnection.m:806)
10 FBSDKCoreKit                   0x103967428 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 839 (FBSDKGraphRequestConnection.m:839)
11 FBSDKCoreKit                   0x103967038 __64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 788 (FBSDKGraphRequestConnection.m:788)
12 CoreFoundation                 0x1a5bfa66c __NSARRAY_IS_CALLING_OUT_TO_A_BLOCK__
13 CoreFoundation                 0x1a5af822c -[__NSArrayM enumerateObjectsWithOptions:usingBlock:]
14 FBSDKCoreKit                   0x103966dfc -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 767 (FBSDKGraphRequestConnection.m:767)
15 FBSDKCoreKit                   0x1039662b0 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 634 (FBSDKGraphRequestConnection.m:634)
16 FBSDKCoreKit                   0x10396443c __36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242)
17 libdispatch.dylib              0x1a58ccb7c _dispatch_call_block_and_release
18 libdispatch.dylib              0x1a58cdfd8 _dispatch_client_callout
19 libdispatch.dylib              0x1a58d9cc8 _dispatch_main_queue_callback_4CF
20 CoreFoundation                 0x1a5ba3cc8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
21 CoreFoundation                 0x1a5b9ea24 __CFRunLoopRun
22 CoreFoundation                 0x1a5b9df40 CFRunLoopRunSpecific
23 GraphicsServices               0x1afe2e534 GSEventRunModal
24 UIKitCore                      0x1a9d29580 UIApplicationMain
25 AllTrails                      0x10233876c main + 21 (UIDevice+Storage.swift:21)
26 libdyld.dylib                  0x1a5a1ce18 start

[mmdock]

similar crash log: SDK version 5.6.0

Fatal Exception: NSInvalidArgumentException
0 CoreFoundation 0x1a5d4c96c __exceptionPreprocess
1 libobjc.A.dylib 0x1a5a65028 objc_exception_throw
2 CoreFoundation 0x1a5c4adcc -[NSOrderedSet initWithSet:copyItems:]
3 CoreFoundation 0x1a5d51048 ___forwarding___
4 CoreFoundation 0x1a5d533a0 _CF_forwarding_prep_0
5 FBSDKCoreKit 0x10174a2e0 +[FBSDKRestrictiveDataFilterManager updateFilters:] + 68 (FBSDKRestrictiveDataFilterManager.m:68)
6 FBSDKCoreKit 0x10174cbac +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 258 (FBSDKServerConfigurationManager.m:258)
7 FBSDKCoreKit 0x10174c418 __78+[FBSDKServerConfigurationManager loadServerConfigurationWithCompletionBlock:]_block_invoke + 162 (FBSDKServerConfigurationManager.m:162)
8 FBSDKCoreKit 0x10173c740 -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41)
9 FBSDKCoreKit 0x10173a030 __82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 801 (FBSDKGraphRequestConnection.m:801)
10 FBSDKCoreKit 0x101739f24 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 834 (FBSDKGraphRequestConnection.m:834)
11 FBSDKCoreKit 0x101739b34 __64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 783 (FBSDKGraphRequestConnection.m:783)
12 CoreFoundation 0x1a5d1e66c __NSARRAY_IS_CALLING_OUT_TO_A_BLOCK__
13 CoreFoundation 0x1a5c1c22c -[__NSArrayM enumerateObjectsWithOptions:usingBlock:]
14 FBSDKCoreKit 0x1017398f8 -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 762 (FBSDKGraphRequestConnection.m:762)
15 FBSDKCoreKit 0x101738db4 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 629 (FBSDKGraphRequestConnection.m:629)
16 FBSDKCoreKit 0x101736f90 __36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242)
17 libdispatch.dylib 0x1a59f0b7c _dispatch_call_block_and_release
18 libdispatch.dylib 0x1a59f1fd8 _dispatch_client_callout
19 libdispatch.dylib 0x1a59fdcc8 _dispatch_main_queue_callback_4CF
20 CoreFoundation 0x1a5cc7cc8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
21 CoreFoundation 0x1a5cc2a24 __CFRunLoopRun
22 CoreFoundation 0x1a5cc1f40 CFRunLoopRunSpecific
23 GraphicsServices 0x1aff52534 GSEventRunModal
24 UIKitCore 0x1a9e4d580 UIApplicationMain
25 Her 0x10008b8e8 main + 11 (main.swift:11)
26 libdyld.dylib 0x1a5b40e18 start

[ericrwolfe]

I'm also seeing a large spike in crashes in the past two hours with the same stack trace. FBSDKCoreKit 6.0.0, Xcode 11.3.1.

[hberberoglu]

We are also experiencing this. It started suddenly about ~1 hour ago. iOSv5.15.1

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x181c16d8c __exceptionPreprocess
1  libobjc.A.dylib                0x180dd05ec objc_exception_throw
2  CoreFoundation                 0x181c24098 __methodDescriptionForSelector
3  CoreFoundation                 0x181c1c5c8 ___forwarding___
4  CoreFoundation                 0x181b0241c _CF_forwarding_prep_0
5  MyAppName            0x100f2ab98 +[FBSDKRestrictiveDataFilterManager updateFilters:] + 68 (FBSDKRestrictiveDataFilterManager.m:68)
6  MyAppName            0x100f2d790 +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 258 (FBSDKServerConfigurationManager.m:258)
7  MyAppName            0x100f1e120 __69+[FBSDKGraphRequestPiggybackManager addServerConfigurationPiggyback:]_block_invoke + 151 (FBSDKGraphRequestPiggybackManager.m:151)
8  MyAppName            0x100f1ca10 -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41)
9  MyAppName            0x100f1a170 __82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 801 (FBSDKGraphRequestConnection.m:801)
10 MyAppName            0x100f1a054 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 834 (FBSDKGraphRequestConnection.m:834)
11 MyAppName            0x100f19c64 __64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 783 (FBSDKGraphRequestConnection.m:783)
12 CoreFoundation                 0x181af0a20 -[__NSArrayM enumerateObjectsWithOptions:usingBlock:]
13 MyAppName            0x100f19a08 -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 762 (FBSDKGraphRequestConnection.m:762)
14 MyAppName            0x100f18e98 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 629 (FBSDKGraphRequestConnection.m:629)
15 MyAppName            0x100f16f7c __36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242)
16 libdispatch.dylib              0x181508aa0 _dispatch_call_block_and_release
17 libdispatch.dylib              0x181508a60 _dispatch_client_callout
18 libdispatch.dylib              0x18151565c _dispatch_main_queue_callback_4CF$VARIANT$mp
19 CoreFoundation                 0x181bbf070 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
20 CoreFoundation                 0x181bbcbc8 __CFRunLoopRun
21 CoreFoundation                 0x181adcda8 CFRunLoopRunSpecific
22 GraphicsServices               0x183ac1020 GSEventRunModal
23 UIKit                          0x18baf9758 UIApplicationMain
24 MyAppName            0x100daf99c main + 16 (main.m:16)
25 libdyld.dylib                  0x18156dfc0 start

[snowtema]

The same problem. My app crashing on live users...

[kevinmun]

Also experiencing huge amount of crashes, still persisting, @tianqibt , any time to resolution or thread where we can check this out?

[rromanchuk]

this again

[kevinmun]

let's merge this into https://github.com/facebook/facebook-ios-sdk/issues/1373

[Yelles]

many apps (Spotify, Viber, etc) are crashing right now... Seems to be a Facebook SDK related issue

[lucas-tl]

We are also affected by this. Please move slower and break fewer things. Thank you.

[johnkassebaum]

What parameterizes 'few' for you?

[pangia]

crashing our entire userbase.

[johnkassebaum]

Ours too

[willswire]

Pinterest, GroupMe apps crashing on launch.

Also, _huge_ iCloud outage right now - mail hasn't been delivered since 6 PM EST yesterday!! Not sure if it's related or not.

[andyjohns]

Yeah, same here. All users regardless if they use FB to login or not.

[rromanchuk]

this is the second time now this SDK has deadmanswitched because of a remote config. I can make my own branching mistakes i dont need additional. Not trying to pile on, but this is not the first time you guys have bricked apps due to release management. It feels a little more nefarious than your typical "server changed response and model now breaks".

[juanchoabdon]

Same error here!

[johnkassebaum]

Still crashing 30 minutes after your revert. Are you sure you reverted the right thing?

[daniel-beard]

@tianqibt "a few minutes" isn't really an acceptable response for a crash that's taken down our entire userbase. Still crashing for me.

What steps in the future will be taken to prevent this?

[AndrewYab]

Are you sure this has been reverted correctly? Our apps are still crashing...

[DanielRaouf]

Affected by this as well. That is very urgent.

[ArielDemarco]

The change needs a some time to be propagated to all server. Some apps already seen the crash stopped. We also turned off the feature. It will be effective within a few minutes.

How much time shall we consider "normal" to wait? Still seeing crashes in our app.

[bruno1308]

Don't fire the intern! We all make mistakes!!

Edit: the world is already hard as is. Put yourself in the shoes of the team that is responsible for this. They must be stressed a.f. knowing that they are crashing the whole iOS ecosystem.
So stop pressuring them and give them time to peacefully make their fixes. Life goes on.

[tinder-nathanglass]

Crashing on launch! Please address!

[marcoviz]

Same here!

[alfonsomestre]

Same!

[Kastet]

This is insane, half of the apps on my phone aren't launching!

[AndrewYab]

Our apps are still crashing. This is unbelievable. Please find a fix urgently!

[scf4]

"lefb-pad"

[tinder-maxwellelliott]

Server side change is already reverted. The crash will vanish.

TLDR; it didn't stop crashing

[PascalJedi]

Is the new slogan,
"Move fast and break the whole mobile iOS app ecosystem!"

[AustinConlon]

Life imitating art.

[krunalsshah]

Hey please treat this is as a pandemic, the apps with iOS Facebook SDK are crashing on app launch.

[obahareth]

Our apps are still crashing as well.

[rms1000watt]

same!

[minhoryang]

Still affected

[yome]

Server side change is already reverted. The crash will vanish.

Narrator: it didn't

[jxom]

My TikTok is crashing!

[c0x65o]

Server side change is already reverted. The crash will NOT vanish.

[jcolicchio]

Crash just vanished for me!

[geremora]

waze crashed too!

[bryankeller]

I hope this damages FB's reputation for sign on - enough that people don't even offer it as a signup option.

[rms1000watt]

how did this get into production? I'm curious of the pipelines/testing they use now...

[minelminel]

is there any way to fix everything except tik tok?

[obahareth]

The crash is beginning to disappear from our users now.

[liverday]

solved it here

[fossage]

Looking good here now 👍

[faridsaud]

It works now!

[DanielRaouf]

[AustinConlon]

_Tim Cook calls Mark Zuckerberg_

_Mark picks up_

Tim: "GOOD MORNING!"

[KeepBotting]

spy apps with spy sdks embedded are crashing
probably deserved

[MeGaPk]

Same here :D

[brtylr]

Spotify still down for me for like the past 2 hours or so, the fix aint fixin' shouts into the void

[corecoding]

Does anyone have an official word from Facebook? It feels like a server outage on their end causing the SDK to parse an invalid payload.

[rromanchuk]

spy apps with spy sdks embedded are crashing
probably deserved

We get it DHH, you didnt take venture.

[v1ctormoreno]

When Facebook ruins the iOS ecosystem: part 9999 please fix this.

[risaluis]

Works!!🤣🤣

[dgutov]

I choose to think this was a good Samaritan somewhere inside FB who now let all users know which of their apps contact Facebook unconditionally during startup.

[whoisjuan]

Some poor bastard at FB right now.

[SzymonFortuna]

From the user perspective - so interesting to see Spotify crashing for me supposing I didn’t sign up with Facebook.

[dwaite]

Edit: the world is already hard as is. Put yourself in the shoes of the team that is responsible for this. They must be stressed a.f. knowing that they are crashing the whole iOS ecosystem.
So stop pressuring them and give them time to peacefully make their fixes. Life goes on.

They should alleviate their stress by removing the telemetry code which is causing this crash. Apps embed this library so that they can let their shared users with Facebook log in; not so that Facebook can track which native apps people are running on their phones.

[johnkassebaum]

There are easy and robust tools for guarding against an eventuality that leads to such significant damage. I, and several at my company, lost an hour+ of productivity, not to mention lost revenue for apps that couldn’t launch to sell or provide their service, or employees that depend on clients being able to order for delivery, etc.. This was no simple mistake; it had lasting damage, the least of which is our crash rate tracking dropping thru the floor. If your code can cause this much damage, that makes you a very large liability.

[kodaewon]

Do you know exactly what the cause of the crash is?

[DirtySoc]

I know this is an unpopular opinion but....

https://github.com/facebook/facebook-ios-sdk/blob/9042193ae6f0c2dc8009b65071cf53d434339004/LICENSE#L12

[lucas-tl]

Do you know exactly what the cause of the crash is?

They aren't checking for nil against a dictionary key. Pretty much CS 101 stuff.
Oh and they're exchanging data with their servers. Without being explicit about this. During the host app launch process :)

[giankotarola]

I have updated my ios phone to V13.4.1 and Spotify was back as many other apps.

[lucas-tl]

I have updated my ios phone to V13.4.1 and Spotify was back as many other apps.

This has nothing to do with the actual update you just did. It's just that the fix they pushed takes some time to propagate. YMMV.

[ColdGrub1384]

Well, let’s now use dlopen so the entire app doesn’t crash when the framework crashes 😂

[NSKevin]

This crash is just like Google Map's crash a faw days before. Backend data error..........
We should make the third-part lib to be plugin, so we can shut them down online : ]
Trust noone -。-、

[yolarrydabomb]

I still don't understand why my Spotify was crashing. I don't use Facebook!

Because their crap code is wrap around the app

[giankotarola]

I have updated my ios phone to V13.4.1 and Spotify was back as many other apps.

This has nothing to do with the actual update you just did. It's just that the fix they pushed takes some time to propagate. YMMV.

@lucas-tl Weird 🤔. I was with two ios devices, both with the apps crashing issue, one was updated to verify if the ios version update could be resolve. When I saw that after the update the apps were back, I updated the other one(that continues with the issues) and then apps were back too. It is Just my experience with the apps crashing problem ✌️

[NikxDa]

Give these guys a break. I'm sure whoever is responsible is having a super shitty day and we all make mistakes. Not a good look calling for the firing of anyone here. Given the size of this piece of software, bugs of this scale are rather rare and it was resolved pretty quickly given that those changes need time to propagate as well.

[lucas-tl]

I have updated my ios phone to V13.4.1 and Spotify was back as many other apps.

This has nothing to do with the actual update you just did. It's just that the fix they pushed takes some time to propagate. YMMV.

@lucas-tl Weird 🤔. I was with two ios devices, both with the apps crashing issue, one was updated to verify if the ios version update could be resolve. When I saw that after the update the apps were back, I updated the other one(that continues with the issues) and then apps were back too. It is Just is my experience with the apps crashing problem ✌️

Yeah I get that. Keep in mind chances are your device flushed DNS cache or something in that process. I can tell you my device went back to normal without doing any update or anything.

[catSIXe]

Give these guys a break. I'm sure whoever is responsible is having a super shitty day and we all make mistakes. Not a good look calling for the firing of anyone here. Given the size of this piece of software, bugs of this scale are rather rare and it was resolved pretty quickly given that those changes need time to propagate as well.

Still does not change the fact, that the Spy Code is causing Problems... Lets just remove it...

[NikxDa]

Give these guys a break. I'm sure whoever is responsible is having a super shitty day and we all make mistakes. Not a good look calling for the firing of anyone here. Given the size of this piece of software, bugs of this scale are rather rare and it was resolved pretty quickly given that those changes need time to propagate as well.

Still does not change the fact, that the Spy Code is causing Problems... Lets just remove it...

I agree but would still argue that this is a different argument altogether :)

[hexafraction]

Can we get a root cause and changes to workflow/testing/process/design to prevent a recurrence of similar issues?

[dfault-user]

this entire thread has me cackling

[austinheap]

Give these guys a break. I'm sure whoever is responsible is having a super shitty day and we all make mistakes. Not a good look calling for the firing of anyone here. Given the size of this piece of software, bugs of this scale are rather rare and it was resolved pretty quickly given that those changes need time to propagate as well.

100% agree -- anyone responsible for SLAs is presumably mature enough to understand this. It is, though, A-grade press fodder 😂

[CoCoKit]

启动后你他娘的瞎更新啥？能不能安分一点儿？？？

[trodick]

Let me just chime in here. As somebody who has had experience, albeit limited, writing software that depends on third-party libraries, this could have been gracefully avoided with better exception handling in the calling code. Anything that is doing something with a server connection should probably be wrapped in a try...catch block. That way, if something upstream does break, or the calling code receives an unexpected value, it can handle the failure without segfaulting and dumping core. I know it's probably a pain in the behind to start wrapping everything in exception-handling code, but it'll save everyone's bacon later on.

[0xmohit]

Every app you run
I'll be watching you

[pangia]

Let me just chime in here. As somebody who has had experience, albeit limited, writing software that depends on third-party libraries, this could have been gracefully avoided with better exception handling in the calling code. Anything that is doing something with a server connection should probably be wrapped in a try...catch block. That way, if something upstream does break, or the calling code receives an unexpected value, it can handle the failure without segfaulting and dumping core. I know it's probably a pain in the behind to start wrapping everything in exception-handling code, but it'll save everyone's bacon later on.

not true in this case. no try/catch block and the entire thing was encapsulated in their SDK.

[JoshCheek]

@trodick that's what I was originally thinking, but it sounds like their code may be calling out to FB when it gets loaded, without the calling code even being aware of this. That's based on this comment: https://github.com/facebook/facebook-ios-sdk/issues/1374#issuecomment-624973970 If so, that's a fkn nefarious thing for their code to do, and calling it "spyware" is almost certainly justified, and wiping out everyone else's apps is to be expected. Again, if so, then the problem isn't their release management, it's the nefarious way they wrote their SDK. 🤔 but, I'm not too confident in that comment, because how would it know which credentials to use when talking to FB on startup?

[NSKevin]

启动后你他娘的瞎更新啥？能不能安分一点儿？？？

Please be rational : ]

[FanYouXin]

A spooky morning！

[trodick]

@JoshCheek Hmmm, but that does make me wonder: Given that the library is open-source, shouldn't a security researcher have already found out what it was doing? Or do you think this is something on the remote end and the client library was receiving an inappropriate value that wasn't handled right? If so, then it's both the client and the API endpoint.

[ScottORLY]

You can disable auto logging app events.

https://developers.facebook.com/docs/app-events/getting-started-app-events-ios

[megs-seek]

You can disable auto logging app events.

https://developers.facebook.com/docs/app-events/getting-started-app-events-ios

Is the logging what is causing the crash? i.e. would this fix the issue?

[WeGamers]

Same ！

[ScottORLY]

Is the logging what is causing the crash? i.e. would this fix the issue?

Maybe 🤷‍♂️ From what I understand the offending line has to do with the event logging and it seems reasonable to assume that it would ameliorate the issue but I haven't verified it myself.

Is your app still crashing?

[megs-seek]

Is the logging what is causing the crash? i.e. would this fix the issue?

Maybe 🤷‍♂️ From what I understand the offending line has to do with the event logging and it seems reasonable to assume that it would ameliorate the issue but I haven't verified it myself.

Is your app still crashing?

were seeing the crash rate about 1/5 what it was 2 hours ago, but there are still significant amount of crashes. still deciding whether its worth releasing a bug fix or waiting for the problem to disappear.. my guess is just to wait

[ademirev]

Seems that the issue is resolved; Spotify and GroupMe, etc. are all up and running on my end.

[ISusu]

How can i fix this issue?

[ISusu]

Four hours ago, the crash rate of my app reached 18%, then it returned to normal, and now it's 15%. Give me a chance, the boss is going to fire me. What should I do?

[allenday]

Edit: the world is already hard as is. Put yourself in the shoes of the team that is responsible for this. They must be stressed a.f. knowing that they are crashing the whole iOS ecosystem.
So stop pressuring them and give them time to peacefully make their fixes. Life goes on.

They should alleviate their stress by removing the telemetry code which is causing this crash. Apps embed this library so that they can let their shared users with Facebook log in; not so that Facebook can track which native apps people are running on their phones.

No, they shouldn't. Facebook has a fiduciary responsibility to their shareholders to monetize surveillance of user behavior.

[MebDevelop]

👊

[ISusu]

It returned to normal now.

[jeannekamikaze]

Just remove the spyware from your software and it will all start working again.

[kazzkiq]

Are we ready to ask the real questions here?

Why the heck does Facebook do unwanted requests during my apps startup? What kind of info are they sending back to their servers?

[poonam-bhadikar]

Is this issue fixed now?

[Kingson]

启动后你他娘的瞎更新啥？能不能安分一点儿？？？

我们的所有App都中招

[Roxasora]

Could someone working for facebook SDK stand out and explain this??😢😢😢😢 This is a real tragedy!! We need to know what happened and why it happened!!😤😤😤😤

[andyjohns]

If you're really curious about what they're doing, just capture it with Charles Proxy. On my app it looks like they're making four calls, three POSTs and a GET, to graph.facebook.com. Haven't spent any time analyzing it, but it looks like they're sending some basic info about the running environment. I see the SDK version in there, our SDK key. Looks like configuration data coming back. Analytics tracking I expect....

[so898]

Maybe it's time to reverse-engineering FB SDK and making a real open source FB login SDK.

[krunalsshah]

Our iOS app is still reporting crashes, for others, have your app's recovered 100%?
Snippet from our error monitoring & reporting tool, still alerting the crash.

NSInvalidArgumentExceptionFBSDKRestrictiveDataFilterManager.m:66 -[__NSCFBoolean objectForKeyedSubscript:]: unrecognized selector sent to instance 0x1e8da5d00
Anyone from the Facebook core team can provide a detailed analysis of the problem?

The question to the Facebook core team

Can we have a configuration to lazy load the initialization only when the app feature requires it?

[mrpuzzler]

Same here:

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x182aa4a48 __exceptionPreprocess
1  libobjc.A.dylib                0x1827cbfa4 objc_exception_throw
2  CoreFoundation                 0x1829a85a8 -[NSOrderedSet initWithSet:copyItems:]
3  CoreFoundation                 0x182aa8af4 ___forwarding___
4  CoreFoundation                 0x182aaaa7c _CF_forwarding_prep_0
5  Game                           0x10058c31c +[FBSDKRestrictiveDataFilterManager updateFilters:] + 80 (FBSDKRestrictiveDataFilterManager.m:80)
6  Game                           0x10058eda8 +[FBSDKServerConfigurationManager processLoadRequestResponse:error:appID:] + 241 (FBSDKServerConfigurationManager.m:241)
7  Game                           0x10058e600 __78+[FBSDKServerConfigurationManager loadServerConfigurationWithCompletionBlock:]_block_invoke + 163 (FBSDKServerConfigurationManager.m:163)
8  Game                           0x1005783c0 -[FBSDKGraphRequestMetadata invokeCompletionHandlerForConnection:withResults:error:] + 41 (FBSDKGraphRequestMetadata.m:41)
9  Game                           0x100575cdc __82-[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:]_block_invoke + 806 (FBSDKGraphRequestConnection.m:806)
10 Game                           0x100575bd0 -[FBSDKGraphRequestConnection processResultBody:error:metadata:canNotifyDelegate:] + 839 (FBSDKGraphRequestConnection.m:839)
11 Game                           0x1005757e0 __64-[FBSDKGraphRequestConnection completeWithResults:networkError:]_block_invoke + 788 (FBSDKGraphRequestConnection.m:788)
12 CoreFoundation                 0x182a7795c __NSARRAY_IS_CALLING_OUT_TO_A_BLOCK__
13 CoreFoundation                 0x18297aed0 -[__NSArrayM enumerateObjectsWithOptions:usingBlock:]
14 Game                           0x1005755a4 -[FBSDKGraphRequestConnection completeWithResults:networkError:] + 767 (FBSDKGraphRequestConnection.m:767)
15 Game                           0x100574a60 -[FBSDKGraphRequestConnection completeFBSDKURLSessionWithResponse:data:networkError:] + 634 (FBSDKGraphRequestConnection.m:634)
16 Game                           0x100572c9c __36-[FBSDKGraphRequestConnection start]_block_invoke_3 + 242 (FBSDKGraphRequestConnection.m:242)

[freezy7]

The crash is still report, and it make the firebase could not refresh out new data. 😠

[mattiacantalu]

Same situation here.. We're using 'FBSDKLoginKit', '5.15.1' (built with Xcode 11.3.1) and the crash is reported live on our users! Please Facebook, provide a fix asap 😰

[bhvk]

Are we ready to ask the real questions here?

Why the heck does Facebook do unwanted requests during my apps startup? What kind of info are they sending back to their servers?

@kazzkiq Checkout Off-Facebook activity logging : https://en-gb.facebook.com/off-facebook-activity
They are going to be the new NSA I presume.

[BradKwon]

I've got some crash report of this last night but it looks stable now although I have tried to log in via Facebook app once. However, better to keep monitoring it since there is not clear fix yet.
My app uses SDK v5.6.0 and logged in from Germany.

[sree127]

Same. Looks "kinda" stable now. No crashes in the last 60 mins at least. 👀

[pepejeria]

https://www.theverge.com/2020/5/6/21250023/facebook-sdk-login-spotify-tinder-tiktok-ios-iphone-crash

“Earlier today, a new release of Facebook included a change that triggered crashes for some users in some apps using the Facebook iOS SDK,” a Facebook spokesperson said in a statement to The Verge. “We identified the issue quickly and resolved it. We apologize for any inconvenience.”

[mqlsq]

启动后你他娘的瞎更新啥？能不能安分一点儿？？？

我们的所有App都中招

我们也是，损失惨重

[mifi]

This is why I like to keep the number of native dependencies in my react-native apps to the minimum

[syedanabimam]

[elecCore]

启动后你他娘的瞎更新啥？能不能安分一点儿？？？

我们的所有App都中招

我们也是，损失惨重

心都碎了，苦苦维持线上1‰的崩溃率，一个更新给我拉升了2%纯涨了2%！是2%！不是2‰！

[AustinConlon]

This thread should be canonized in the Computer History Museum.

[DeepakTivari]

Facebook and their spywares

[dongshuju]

启动后你他娘的瞎更新啥？能不能安分一点儿？？？

我们的所有App都中招

我们也是，损失惨重

心都碎了，苦苦维持线上1‰的崩溃率，一个更新给我拉升了2%纯涨了2%！是2%！不是2‰！

一夜回到解放前

[AustinConlon]

In 2014 Facebook updated the company mantra and it was a wonderful thought. Any chance we could have it added to this repository's README?

[santaasus]

I have some issue in restrictiveParams[eventName][@"is_deprecated_event"], but there isn't condition for dictionary like [restrictiveParams objectForKey], there is force unwrap by key

[AustinConlon]

All rise for the Facebook iOS SDK anthem.

Anti-Patterns
Coding practices you should avoid
Anti-Patterns
So your app don’t crater like a meteoroid

Whether you’re a newbie or here since NeXTSTEP 3.3
There’s a chance you’ve picked up some bad habits
So take my advice, make your code play nice
Or the bugs will multiply like rabbits
Doo, doo da doo doo

Anti-Patterns
Yeah, you know they’re gonna bite you somewhere down the line
Anti-Patterns
Even if the code seems to work at the time

[RubenKelevra]

Quite interesting how many apps report each startup to Facebook... probably with the user ID.

You should consider to remove the Facebook functionality from your app entirely.

[balazserd]

Quite interesting how many apps report each startup to Facebook... probably with the user ID.

You should consider to remove the Facebook functionality from your app entirely.

Yup. If you actually look at what Facebook does is it immediately sends all device info + carrier and also adds an advertisement ID.

I bet a lot of apps don't disclose this information in their privacy policies.

[PatoGuereque]

I don't know what's scarier, the fact that this basically acted as a remote kill switch for hundreds of apps or that the SDK _silently_ sends data on startup

[allenday]

Maybe it's time to reverse-engineering FB SDK and making a real open source FB login SDK.

Maybe it's time that we take responsibility for managing our own private keys and move beyond SSO services for personal data.

[ArtFeel]

@balazserd It also swizzle all your UIView, UITextField, UIControl, etc., and add StoreKit observer, to know all about what your users see and theirs purchases.

[allenday]

I don't know what's scarier, the fact that this basically acted as a remote kill switch for hundreds of apps or that the SDK _silently_ sends data on startup

The functional code should be scary to you.

The kill switch should be scary to FB.

The latter because it raised FB's intentional behavior of harvesting user data to the level of awareness of developers.

[nirui]

In 2014 Facebook updated the company mantra and it was a wonderful thought. Any chance we could have it added to this repository's README?

The app crashed while trying to output _INFRASTRUCTURE_.

[CailinPitt]

This was a real eye-opening experience. Might have to stop using a lot of the apps that have been communicating with Facebook without my knowledge.

[behdaad]

Let this be a lesson to all of us. We all make mistakes, even the best of us. Stay safe, stay humble.

[petermjones]

Facebook fixing the server configuration is not good enough. At least two things must be done:

1. SDK should not crash, regardless of what information comes back from Facebook's servers.
2. Full transparency as to why it is connecting and what information is being shared.

As App writers, we're deliberately ignoring the fact that the more dependencies you have, the more brittle our systems become. We need to re-think that strategy.

[tianqibt]

A new release of Facebook included a change that triggered crashes for some users in some apps using the Facebook iOS SDK. We identified the issue quickly and resolved it. We apologize for any inconvenience

[krunalsshah]

Thanks for fixing the issue.

Our iOS app is still reporting crashes, for others, not sure if the apps have recovered 100%? @tianqibt what do your monitoring tools show?

We'd appreciate more details.

• Why does the initialization call fire at launch time, and not lazily loaded?
• Is there a way to configure the SDK such that it could lazily load? And could that change propogate to react-native-fbsdk?

Snippet from our error monitoring & reporting tool, still alerting the crash.

-[__NSCFBoolean objectForKeyedSubscript:]: unrecognized selector sent to instance 0x1e8da5d00

[timuren]

How many apps out there still appear to be impacted?

[akhilpothana]

Facebook fixing the server configuration is not good enough. At least two things must be done:

1. SDK should not crash, regardless of what information comes back from Facebook's servers.
2. Full transparency as to why it is connecting and what information is being shared.

As App writers, we're deliberately ignoring the fact that the more dependencies you have, the more brittle our systems become. We need to re-think that strategy.

@petermjones exactly! especially the fact that even a large well versed tech company's sdk can break

[lordzsolt]

Thanks for fixing the issue.

Our iOS app is still reporting crashes, for others, not sure if the apps have recovered 100%? @tianqibt what do your monitoring tools show?

We'd appreciate more details.

• Why does the initialization call fire at launch time, and not lazily loaded?
• Is there a way to configure the SDK such that it could lazily load? And could that change propogate to react-native-fbsdk?

Snippet from our error monitoring & reporting tool, still alerting the crash.

-[__NSCFBoolean objectForKeyedSubscript:]: unrecognized selector sent to instance 0x1e8da5d00

How would you expect Facebook to track all your users if they don't fire at first launch?

[virtadpt]

They are going to be the new NSA I presume.

"Going to be?"

[kconner]

A new release of Facebook included a change that triggered crashes for some users in some apps using the Facebook iOS SDK. We identified the issue quickly and resolved it. We apologize for any inconvenience

@tianqibt To be clear, are you saying this was fixed on the server side, and released apps should no longer exhibit the crash? It's not necessary to update apps with a new Facebook SDK version?