Fabric.js: Missing full gradients support for canvas background

[sandor]

Is it possible now with 2.0.0 to set a gradient for the canvas object?

[asturur]

i think it has always ben possible, if there are difficulties, is time to fix it.

As of now you have to enlive the gradient on your self i think.

canvas.backgroundColor = myGradient.toLive()

[asturur]

Please share your use case with a fiddle

[sandor]

Not sure if i understand this right – but maybe you could give a hint on this fiddle?

http://jsfiddle.net/tmchz9h0/5/

[asturur]

http://jsfiddle.net/tmchz9h0/9/

this is an example that show that is possible, just hard to do and uncomfrotable.
I will not make it for release fo 2.0.0, but immediately after yes.

[sandor]

thank you very much! it is workin with 2.0.0-beta3

[sandor]

One additional question to this approach – should this be working also (defining coords with %)?

var grad = new fabric.Gradient({ type: 'linear', coords: { x1: "50%", y1: "0%", x2: "50%", y2: "100%", }, colorStops: [ { color: leftColor, offset: 0, }, { color: rightColor, offset: 1, } ] });

Or did you worked on the gradient angle function (I know I was reading about this somewhere)... ?

[ncou]

@asturur : why is it "hard to do and unconfortable" ? It looks like you can pass a pattern object, but also a gradient object to the .setBackgroundColor() function.

http://jsfiddle.net/tmchz9h0/10/

But this information is not present in the documentation (it say : a string or a pattern object, it doesn't speak about a gradient object).

Am i missing something ?

[asturur]

well there is a difference between the object structure of a gradient when you want to set with the 'setGradient' method or when you want to create it with constructor.

that is bad.

Also the objects have a setGradient method and the canvas not.

I would like to get a simpler gradient interface but that is more breaking changes and i do not want to do them now.

[asturur]

@ncou yes the docs are probably outdated

[ncou]

thank you, now it's more clear.

as always my 2 cents opinion : adding a setGradient() function to the canvas object, could be an overkill, today setting a background with fabric.js is not really clear if you don't read carfully the doc => you can use "setBackgroundImage()" with an url, an image object, a rect object [who can include a pattern object], and you can use "setBackgroundColor()" with a rgb string, a pattern object, and a gradient object.

[asturur]

i guess the safest is to deprecate both, keep them and add a generic setBackground that can handle both plus gradients and patterns.

[ncou]

this could be a really clean solution, having one entry point to set a background is more easy.
Perhaps a bit tricky to for those who want to add both a background color AND a picture background.

[asturur]

you just call it twice. needs just a better doc and explanation.

[sandor]

@asturur while we are on this: there where some plans to introduce an angle for gradients instead of x1,x2,y1,y2 –. Are they abbandoned now?

[asturur]

no they are not.

the plan is making gradients simpler in some way, but mantain svg compatibility.

svg heavily relies on that coords and gradient transform, while who creates gradients by code could easily use something easier.

like percentages and angles.

[asturur]

From @ncou

Thank you.
I encounter a strange behaviors => I could make the gradientTransform work when i set the gradiant using "setGradient()" on a rect, but i create a new object calling directly the gradient object, i could not make it work.
I checked in the constructor (initialize function) and it should take my matrix.

Here is my fiddle :
http://jsfiddle.net/tmchz9h0/17/
TEST 1 is ok (if you uncomment the line 61, the rect with the transformed radial is applied).
TEST 2 is ko if i use a setbackgroundcolor with the new fabric.Gradient object created.

I even tried something like : grad.gradientTransform = fabric.parseTransformAttribute([1,0,0,2,1,1]); after creating my Gradient object. but without success.

[dedanirungu]

I have tried to change the linear gradient to radial but it did not work.

http://jsfiddle.net/sckkfj10/

[ncou]

you need to use the correct parameters (r1 and r2 are missing).
http://jsfiddle.net/sckkfj10/1/

[Alwenjohn]

how can i set the canvas background with color picker?

[asturur]

@alwenjohn we can t really help with application problems here, please open a stackoverflow question and link it here eventually

[rikkarv]

I tried:
canvas.backgroundColor = myGradient.toLive()

However when I do json stringify from canvas.toObject() to store the canvas in the database for later upload I get _"{"version":"2.7.0","objects":[],"background":{}}"_ because the value of 'background' property is an 'CanvasGradient'

[asturur]

i think gradients are supported if i'm not wrong.
Just assign a gradient fabric object?

[rikkarv]

Yes Andrea, you are right.
I have tried to assign a gradient fabric object, as you suggested, and it worked.
Thank you once more.

---

De: Andrea Bogazzi [e-mail]
Enviado: 27 de abril de 2019 10:20
Para: fabricjs/fabric.js
Cc: Ricardo Carvalho; Comment
Assunto: Re: [fabricjs/fabric.js] Missing full gradients support for canvas background (#4232)

i think gradients are supported if i'm not wrong.
Just assign a gradient fabric object?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/fabricjs/fabric.js/issues/4232#issuecomment-487270164, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJUVR7SFFFOSZZY5HQGDZC3PSQLEDANCNFSM4DXVF4IA.

[rikkarv]

However I have found that when zooming the canvas or using toDataURL with multiplier (https://jsfiddle.net/8d30cfj1/1/) the gradient doesn't scale.
I believe that this is not the same behaviour that background images have.

[asturur]

oh that is weird. it should scale. i ll check.

[asturur]

there is a flag in fabric for background zoom. It was a contentested option, some people thought it should scale other though it should not. Did you try it?

[asturur]

http://fabricjs.com/docs/fabric.StaticCanvas.html#backgroundVpt

[asturur]

Doesn't work with it either, is a bug.
probably something easy, like the gradient is done before the zoom is applied, an easy fix with random side effects.

[rikkarv]

Thank you for your time on this.
I'm not working today but tomorrow i will look at this in more detail and i will give you some feedback as soon as possible.

---

From: Andrea Bogazzi [e-mail]
Sent: Wednesday, May 1, 2019 11:21:15 AM
To: fabricjs/fabric.js
Cc: Ricardo Carvalho; Comment
Subject: Re: [fabricjs/fabric.js] Missing full gradients support for canvas background (#4232)

http://fabricjs.com/docs/fabric.StaticCanvas.html#backgroundVpt

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/fabricjs/fabric.js/issues/4232#issuecomment-488251059, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJUVR7RRSY4HRQBE6FMQF6TPTFVJXANCNFSM4DXVF4IA.