Fable: Rollup plugin doesn't generate source maps

[inosik]

Description

When using the Rollup plugin, Rollup generates a warning about broken source maps. The condition in the plugin seems to be incorrect, when I change it to if (true), the warning described below disappears. The Rollup wiki says that plugins that transform source code should generate source maps automatically, so I wonder if we should remove the condition altogether.

Repro code

Clone my VS Code extension sample repo, restore the packages and build it with dotnet fable yarn-run build.

Expected and actual results

(!) Broken sourcemap
https://github.com/rollup/rollup/wiki/Troubleshooting#sourcemap-is-likely-to-be-incorrect
Plugins that transform code (such as 'fable') should generate accompanying sourcemaps

Related information

• Fable version (dotnet fable --version): 1.2.0
• Rollup plugin version: 1.1.0

[alfonsogarciacaro]

You're right, probably it's a good idea to remove the condition for the Rollup plugin, could you please send a PR? Thanks a lot in advance!

[inosik]

See #1142.

[alfonsogarciacaro]

rollup-plugin-fable 1.1.1 published :+1:

[inosik]

Yes, I already updated my packages and the warning is gone. Thanks!