Fable release doesn't push tags to github

[forki]

Description

it's extremely hard to see what changed between two releases if we don't push tags to github.

[alfonsogarciacaro]

@fable-compiler/infrastructure

There's a FAKE target here which I basically copied from FCS repo, we can adapt that.

[alfonsogarciacaro]

Anybody from the @fable-compiler/infrastructure team volunteering for this? From now on I will always update the three main Nuget packages (Fable.Core, Fable.Compiler and dotnet-fable) at the same time so the versions are synced. That way we can use that version updates to tag the releases.

[leolorenzoluis]

I can take a look at it. @alfonsogarciacaro Do you already have an idea in mind on how you want to implement this? I assume it's not just doing Github tags, but also reading the md files for the release notes?

[alfonsogarciacaro]

Awesome @leolorenzoluis, thanks! I don't have any idea specifically. The most important thing is the tags so we can make git diffs when we find a regression bug after a new version is published. Reading the release notes would be nice. As we'll be pushing the 3 Nuget packages at the same time (and I also plan to put the fable-core JS files directly into the Fable.Core nuget package), maybe it's easier to merge the release notes files (currently there's one release notes file, all in the repo root, for each of the packages).

About uploading a binary or the nuget package to Github I don't think it's very important for now.

[forki]

If you look into paket's own build script you can see how to create git
tags, github tags and how to upload files and release notes to github.

Am 11.05.2017 11:37 nachm. schrieb "Alfonso Garcia-Caro" <
[email protected]>:

Awesome @leolorenzoluis https://github.com/leolorenzoluis, thanks! I
don't have any idea specifically. The most important thing is the tags so
we can make git diffs when we find a regression bug after a new version is
published. Reading the release notes would be nice. As we'll be pushing the
3 Nuget packages at the same time (and I also plan to put the fable-core JS
files directly into the Fable.Core nuget package), maybe it's easier to
merge the release notes files (currently there's one release notes file,
all in the repo root, for each of the packages).

About uploading a binary or the nuget package to Github I don't think it's
very important for now.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fable-compiler/Fable/issues/872#issuecomment-300924123,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNONnqEAt_pn5NLCpBVEirDg-4uR-ks5r43-fgaJpZM4NQaMV
.

[leolorenzoluis]

Thanks @forki. I assume it is just on build.fsx, but do you have some specifics where I can look at? Is it just the "ReleaseGithub"?

[forki]

Yeah only build.fsx

Am 12.05.2017 7:05 nachm. schrieb "xyz" [e-mail]:

Thanks @forki https://github.com/forki. I assume it is just on
build.fsx, but do you have some specifics where I can look at? Is it just
the "ReleaseGithub"?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fable-compiler/Fable/issues/872#issuecomment-301132150,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNBrTzQ82o9Mu0SJD6Q4udPsIio4Kks5r5JFDgaJpZM4NQaMV
.

[Zaid-Ajaj]

@alfonsogarciacaro This one can be closed, right?

[alfonsogarciacaro]

That's right @Zaid-Ajaj, thanks for pointing it out!