Fable node process not killed on compilation failure

[whitetigle]

Description

When bundling fails, fable crashes and let the process alive.

So we need to kill the process by hand.

Related information

• Fable Version 0.7.18
• .NET Runtime, CoreCLR or Mono Version 4.4
• windows 10

[whitetigle]

...and before you ask, bundling fails when the import directive fails

type [<Import("MyNaughtyObject","foo")>] MyNaughtyObject(options:obj) = ...
where "foo" is unresolved

(there it's "" that's unresolved)

[alfonsogarciacaro]

Can you please try with latest version? I changed it so the app doesn't crashes in watch mode when there're bundling errors :)

[whitetigle]

⁉️ could not reproduce the error this morning with both 0.7.18 and 0.7.19.

What I can say is that it does not crash (and it bundles). So I miss some other parameter to reproduce the problem. I should have created a test case... Would you have any idea to make bundling fail so I can test ?

If not let's say it solved. And if I encounter other bundling error in watch mode I will update this issue to say how things went.

[MangelMaxime]

@whitetigle To force a bundle error you could remove a deps from your node_modules or ask to import a fake one. This should force Rollup to failed.

[whitetigle]

Thanks @MangelMaxime!
So I renamed fable-core folder and saved my .fsx to see what happened.

Here is the result: infinite loop of rebuild

Hope it will give you some more information

[alfonsogarciacaro]

Hehe, I was just thinking I had introduced the possibility of an infinite loop and hoped nobody noticed and then I read your comment ;) Can you please give it a new try with fable-compiler 0.7.20?

[whitetigle]

Ok! Seems good now!