Faas: Proposal: Migrate all OpenFaaS projects to dep vendoring

[stefanprodan]

Use dep project wide.

Projects

• [x] openfaas/faas
• [x] openfaas/faas-swarm
• [x] openfaas/faas-netes
• [x] openfaas/faas-cli
• [x] openfaas/faas-provider
• [x] openfaas/nats-queue-worker
• [x] openfaas-incubator/faas-o6s

[alexellis]

We'll do the faas gateway with the changes in #460. The faas-cli will be easier to change after this PR. Same difference for openfaas/faas-netes I would have thought.

I don't think the watchdog vendors packages yet or of-watchdog. (so we could take them off the list)

[alexellis]

@BurtonR want to test out derek here to add the label of proposal?

[burtonr]

Derek add label: proposal

[ericstoekl]

Can we get brief instructions on how to convert the projects to use dep for vendoring? Something like, delete the vendor/ directory, run dep init, then run dep add on each package that is still missing? Or is there more to it?

[stefanprodan]

@ericstoekl dep init should be enough but in same cases the package doesn't have a sem ver release or the release is very old. In these cases you can override the revision git sha in the Gopkg.toml, here is an example.

[stefanprodan]

One more thing, the Gopkg.toml should contain only the imported packages from your code, dep will add the inner dependencies to Gopkg.lock when you run dep ensure.

[alexellis]

So it's just like vndr - we do an init up front then later on do an ensure -add or ensure -update to add/maintain dependencies. I've just updated the contribution guide with a link to the dep homepage.

https://github.com/golang/dep

[imumesh18]

If anyone is not working on migrating faas-cli I would like to take that.

Cc / @alexellis @stefanprodan

[alexellis]

Please feel free @dungeonmaster18 - just raise the PR without the vendor folder 👍

[imumesh18]

Hey @stefanprodan migration of faas-cli to dep has been merged. Please mark it done in the description of this issue.

[stefanprodan]

Done. Thanks @dungeonmaster18

[stefanprodan]

@dungeonmaster18 do you want to go for nats-queue-worker next?

[imumesh18]

Yes, I will create the pr by today. Also I was going through faas-netes it also seems easy but I am not sure due to it's large dependency on k8s. Has anybody tried migrating faas-netes? @stefanprodan

[stefanprodan]

I think we will do faas-netes when porting the code for faas-o6s. I would also wait for the gateway to be merged with the new faas-swarm.

[alexellis]

Hey it doesn't hurt to do this migrating to dep now, but we will have to re-vendor again when #460 is complete and the gateway shrinks down to a much smaller since. #460 removes Docker swarm from the gateway.

[imumesh18]

Okay I will only work on nats-queue-worker.

[imumesh18]

Hey @stefanprodan mark nats-queue-worker done. Also I seen certify-incubator which also needs to move to dep. But I was thinking of keeping it for good-first-issue.

[alexellis]

Derek close: thanks to everyone who worked on this.