Faas: Watchdog review: fprocess variable

[alexellis]

I'd like to discuss the experience of using the watchdog especially the fprocess variable which some of us understand to mean fork_process.

Can we improve on the name of the variable?

This issue is open for discussion - please do not create a PR.

[udondan]

I thought it meant faas_process.

In general I think it is important to namespace environment variables to avoid conflicts with other software.

I also prefer uppercase for environment variables.

Therefore my choice would be: FAAS_PROCESS

[rgee0]

Taking a semantic approachprocess implies a running state. Within a container the Watchdog is running and upon function invocation the Watchdog issues a command to satisfy the function request.

If the nomenclature is to change then I'd suggest involvement of command rather than process.

[alexellis]

command will conflict with CMD - the container directive. All OpenFaaS env-vars are currently lower_case @udondan

faas_command - might work better but is pretty long

Maybe faas_cmd / fork_cmd?

[alexellis]

@trusch I know you've been looking at the watchdog. Any thoughts from your side?

[LucasRoesler]

I like the idea of name spacing faas_cmd seems reasonable and clear. Although would it be more correct to say watchdog_cmd?

[trusch]

I think prefixing with the project name is quiet common to prevent collisions with other variables. So the only question is, what is the project name ;) From my point of view the current fprocess variable is specific to the openfaas/faas/watchdog implementation so either watchdog_cmd or fwatchdog_cmd would come to my mind.

[Lewiscowles1986]

fwatch_cmd for brevity and clarity? :thinking:

I quite like @alexellis suggestions above.

[stealthybox]

I always thought it meant function-process because it's used by the Function Watchdog.

I like faas_cmd or watchdog_cmd.
function_cmd is also nice.

[alexellis]

Thanks for the suggestions.

function_process and fprocess are now both supported in the new of-watchdog project. Happy to review again before releasing of-watchdog.

https://github.com/openfaas-incubator/of-watchdog