External-storage: External Controller should support `Retain` volume reclaim policy

Created on 30 Aug 2017 · 10Comments · Source: kubernetes-retired/external-storage

As patch https://github.com/kubernetes/kubernetes/pull/47987 is merged, I think we can support Retain policy in external-storage.

https://github.com/kubernetes-incubator/external-storage/blob/master/lib/controller/controller.go#L785

I'm working on a patch on this.

/cc @wongma7

arelib

Source

xingzhou

Most helpful comment

Greetings! First off, I love everything you all are doing. Thanks so much. I see that #304 and #331 are merged in. Any word on getting 'retain' added in? I'd love to add that in for my EFS provisioning :)

boomshadow on 15 Dec 2017

👍6

All 10 comments

@wongma7, the kubernetes/api repo does not contain the latest for ReclaimPolicy field? is that possible to update that repo?

xingzhou on 30 Aug 2017

Seems the sync is broken again https://github.com/kubernetes/test-infra/issues/4080. IMO we just have to wait, I'll keep an eye on it. The alternative is patching k8s.io/api ourselves which is a lot of work

wongma7 on 30 Aug 2017

@xingzhou kubernetes/api has been updated https://github.com/kubernetes/api/blob/f30e293246921de7f4ee46bb65b8762b2f890fc4/storage/v1/types.go#L51

wongma7 on 5 Sep 2017

we can wait for https://github.com/kubernetes-incubator/external-storage/pull/304 and https://github.com/kubernetes-incubator/external-storage/pull/331 to merge before updating our dependencies, else there will be a lot of rebasing pain

wongma7 on 5 Sep 2017

yeap, thx @wongma7, I'll carry on the patch

xingzhou on 6 Sep 2017

boomshadow on 15 Dec 2017

👍6

Any movement on this one? Just began using EFS provisioning a few days ago and today realized there did not appear to be a way to retain; after pvc deleteition. Thx Guys!

d-mcd on 21 Feb 2018

@d-mcd and @boomshadow, just saw your comments, sorry for the late response. Please take a look at my latest comments in the PR.

The main code for supporting retain policy has been merged in another PR, and this feature only support K8s higher than v1.8. Would you please take a trial on this feature and let me know if anything not work correctly? thx

xingzhou on 22 Feb 2018

not sure if we should discuss this further here or in the PR, so will paste a link to my comment in the PR , https://github.com/kubernetes-incubator/external-storage/pull/392#issuecomment-370848257