External-dns: Increase logging output

[linki]

external-dns currently doesn't log anything if it's not running in dry-run mode. Change that!

[hjacobs]

At least all performed DNS changes should be logged as INFO (one line per change, not some verbose dump).

[hjacobs]

@ideahitme can you prepare a small proposal on where to log what? I have some minimum expectations (just what comes to my mind right now):

• DNS records which are not owned by External DNS should be logged on DEBUG level (so users can clearly see that they are skipped and for what reason)
• DNS records which are filtered by the --domain option should be logged on DEBUG level (so users can clearly see that they are skipped and for what reason)

[ideahitme]

Logging should include (without --debug enabled) :

• [x] External-dns final changes passed to dns provider - this needs to be logged in DNS Provider mainly due to RecordType information
• [x] All errors regarding retrieving ingress/service and dns provider API calls:
  
  
  
  • [x] Failure to retrieve ingress/service list, failure to retrieve record list should be logged in controller
  
  
  • [x] Failure to update records in a hosted zone, logged in dns provider with zoneID and list of records - this is a rare scenario
  
  
• [ ] External-dns has empty update list for dns provider - this should be transparent, i.e. each dns provider call to update records should be concluded with number of owned records (k8s resources) and number of changes pushed to DNS Provider

Debug logging should include:

• [x] External-dns is unable to determine a hosted zone for the record - this information is only available in DNS provider and should be logged there
• [x] External-dns is not responsible for the record (TXT record is missing) - this information is only available in TXT Registry
• [x] External-dns skips endpoint because another controller annotation is present or dnsname could not be figured out - this information should be logged in corresponding source implementation
• [x] External DNS policy does not allow deletion, this information should be logged with a list of record which are not being deleted due to the policy
• [ ] External DNS resorting to compatibility mode (if flag enabled) should be seen by user - e.g. "mate zalando.org/dnsname annotation is found, using example.org as dns name"
• [x] External DNS should print general information regarding collected k8s resources [DNSName Target]

[hjacobs]

Also debug logging should include if a change is not performed because of the policy (e.g. a DELETE would be needed but is not allowed by policy).

[hjacobs]

External-dns has empty update list for dns provider

I think this could be a nice summary logging the number of owned records and performed changes.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.