Ex_doc: [Mobile] Sidebar disappears when clicked in search box
This is happening in Chrome browser for Android, in hexdocs.pm
eksperimental
All 11 comments
Which URL precisely? And can you please post a screenshot? :)
josevalim
on 2 Jun 2017
@josevalim I suppose any URL would work, for example, https://hexdocs.pm/ecto. I was unable to reproduce it in any of the desktop browsers, but it reproduces on Android in Chrome 58.0.3029, Firefox 53 and Opera Mini 25.0.2254. Unfortunately, I don't have any Apple devices to confirm that the bug is present there as well.
It should not be related to responsive layout because changing the viewport size on desktop makes no effect. The only thing that comes in mind is touch events but I don't remember any explicit usage of them in ex_doc.
UPD: it also seems to be not reproducible in Chrome device emulator.
nscyclone
on 2 Jun 2017
It works fine on iOS (10.3.2) if that's helpful.
aphillipo
on 2 Jun 2017
Correct. It happens in any URL, in landscape and portrait view
eksperimental
on 2 Jun 2017
And a screenshot wouldnt work, as it dissapears instantly as if you were closing thr side panel
eksperimental
on 2 Jun 2017
Might be worth taking a photo of a live phone then, at least everyone would be able to see it?
aphillipo
on 8 Jun 2017
The change is instant. if you want a before is with the sidebar open, and the after is with no side bar.
you can only see that recording a screencast.
eksperimental
on 8 Jun 2017
Browsers running on android will trigger the resize event when the on-screen keyboard pops up. Since the initialize function in assets/js/sidebar.js adds a listener on window resize, the sidebar will be closed every time a resize happens.
I guess the solution would be to either remove the event listener on window resize, or only close the sidebar if the width changed (ignoring the height).
profil
on 9 Jun 2017
Huge thanks to everyone. I suppose that #742 should fix the issue.
nscyclone
on 13 Jun 2017
Thank you @nscyclone for fixing this issue.
Amazing work!
eksperimental
on 26 Jun 2017
@josevalim I think we need to make a new release as this is a very annoying bug if you are checking docs in a mobile
/cc @ericmj
eksperimental
on 26 Jun 2017
Related issues
wojtekmach
·
3Comments
akrisanov
·
8Comments
joshprice
·
6Comments
kianmeng
·
4Comments
ericmj
·
8Comments
Most helpful comment
Huge thanks to everyone. I suppose that #742 should fix the issue.