Current behaviour:
Expected Behaviour:
Feature to be added:
screenshort: https://ibb.co/7WfJ2GR
I think this is a duplicate of https://github.com/Cloud-CV/EvalAI/issues/1934
@nikochiko Yes the email part is same as #1934, i missed to look up on the other's issues.But what about feature part and second part of this issue?
Can you elaborate on why you think it will be better to redirect to the home page?
After signing up,user don't usually prefer to enter their details again. So it would have been if after signing up, user would have been directed to the home page showing a message telling them to verify their email Id. And after verification, the home page will be refreshed to get the actual home page.
@nikochiko I think @Kajol-Kumari is saying right. it does make more sense to redirect to home page instead of showing a message with "false" on dashboard when user sign up and also we should redirect the user who log out to landing page or homepage . I have personally feels quite annoying when I am redirected to log in page just after log out.
@Kajol-Kumari Nice point! :100:
I think the philosophy behind redirecting to the login page is this:
-> After filling sign-up details, we do not log the user into the server by default.
-> So, if the user gets to the homepage first
-> he/she will have to go to the login page anyway in order to sign-in.
(Let me know if I am missing something).
So if I understand correctly, what you mean is to log in user automatically after signing up, and allow some limited functionality until the user is verified. Is that right?
yes @nikochiko It would also be better if with limited functionality, a message will be attached to their dashboard telling them to verify their email ID in order to get the full access rights.
@Kajol-Kumari @nikochiko I think the limited functionality aspect is already implemented in the form of the error message saying to verify the email .?
@Suryansh5545 I am not sure whether i got your question or not but currently after someone do sign up and login without email verification.That person is not even able to access his/her dashboard.So by limited access i mean to have access to one's dashboard only showing them the message to complete the verification process till they verify their email.
@Kajol-Kumari Great! Can you open another issue or change the title of this one accordingly then?
The issue mentioned in the title has been clarified #1934.
Also, could you please add a list of the additions you want to see? We could split the addition into multiple steps. That will make both the contribution and review easier. And also allow anyone new to know about the feature request and provide feedback.
@Suryansh5545 I meant limited functionality as in allowing an unverified user to view challenge details.
@nikochiko there is a pr for this ability and it was actually the task of GCI
@Kajol-Kumari so you want to show the dashboard with the please verify your email message?
@Suryansh5545 I want to show the normal dashboard with count of challenges and participants(will always be 0 for new user) and along with that, an attached message telling them to verify their email id to have full access i.e creating host,creating participant,creating challenges etc.
@Suryansh5545 I want to show the normal dashboard with count of challenges and participants(will always be 0 for new user) and along with that, an attached message telling them to verify their email id to have full access i.e creating host,creating participant,creating challenges etc.
Got it:+1:
@Kajol-Kumari but perhaps I will suggest to get a maintainer advise on this issue
@Suryansh5545
@nikochiko there is a pr for this ability and it was actually the task of GCI
I know, I was just giving an example. :)
@RishabhJain2018 please have a look at the suggestions.
Thanks @Kajol-Kumari , @nikochiko and @Suryansh5545 for the suggestions. I think what you guys are proposing makes sense. I'm summarizing the above suggestions here -
Please let me know if I missed anything.
Also, would anyone of you like to work on this in three different PR's so that it will be easy for me to review and merge.
Thanks @Kajol-Kumari , @nikochiko and @Suryansh5545 for the suggestions. I think what you guys are proposing makes sense. I'm summarizing the above suggestions here -
- A new user should be logged-in directly after signup instead of redirecting to login page.
- The message on the dashboard for verifying the email should be meaningful giving the reason.
- Even if the email isn't verified, the user should be able to view the challenges.
Please let me know if I missed anything.
Also, would anyone of you like to work on this in three different PR's so that it will be easy for me to review and merge.
Yes @RishabhJain2018 These are the features we want to add on. Also i would like to work on it and @nikochiko and @Suryansh5545 you people can also work on the same as there are 3 features so will have 3 PRs for this. Please let us know if you have enough time to work on this(As you people have exams going on). Meanwhile, I would like to go with first part i.e Redirecting user to Dashboard with meaningful message.
@Kajol-Kumari My exams will be over by 3 march. But I will take a gaming break for a week after my exams so you go ahead.:+1:
@RishabhJain2018 one thing i would like to add as suggested by @Suryansh5545 that it would be better if we direct the user to home page rather than login page after they logout. Sir, please let me know should i go for it or not.
We discussed about this issue and here is the updated plan:
Basically, until the user has verified their email address, they won't be go to dashboard. @Kajol-Kumari can we please add this to Frontend V2?
Most helpful comment
@Kajol-Kumari My exams will be over by 3 march. But I will take a gaming break for a week after my exams so you go ahead.:+1: