Evalai: Add tests for the add_participant_team_to_challenge API

Created on 11 Feb 2019  路  10Comments  路  Source: Cloud-CV/EvalAI

Add tests for adding participant team to the challenge API if the challenge is docker based.
The API is written here.
For mocking the boto3 requests to ECR, please use https://github.com/spulec/moto

GSOC-2019 backend easy_to_fix enhancement good first issue inactivity

Most helpful comment

@yashdusing Thank you for your explanation!
@kurianbenoy I'm sorry for my late response. I'm still working on this issue.

All 10 comments

Can I work on this issue?

Sure @Mike-Dai You can work on this.

@RishabhJain2018 Since it's my first time to write tests I'm confused about it. Should I add tests in class MapChallengeAndParticipantTeam(BaseAPITestClass) in tests/unit/challenges/test_view.py?

@RishabhJain2018 I should test whether the ecr repository is successfully created or not and whether the participant team has the correct docker_repository_uri or not, right? Please correct me if my understand is wrong.

@Mike-Dai can I work on this issue. If you are feeling difficulty to understand this issue?

Can I take up this issue?

@Mike-Dai I鈥檒l try to solve the confusions you have.
@RishabhJain2018 correct me if I鈥檓 wrong.
The tests will be of the following things:

  1. The one you mentioned
  2. Make another same name participant team and check whether the docker ecr entry is the same.
  3. Hidden test cases like getting ecr name wrong, etc.
    There might be some I missed and I think @RishabhJain2018 can explain these better but you can get started writing these first off

@yashdusing Thank you for your explanation!
@kurianbenoy I'm sorry for my late response. I'm still working on this issue.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically closed as there is no further activity. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings