Evalai: Modify challenge phase query for displaying challenge phase detail

Created on 5 Jul 2018 · 14Comments · Source: Cloud-CV/EvalAI

Current Scenario:
The function here will not throw the error even if there are no challenge phase corresponding to the challenge.

Steps to Reproduce: You will only be able to check it only at the API level.
Let us suppose there exists a challenge with id 34 and phase ids 120, 121. Now when you will hit the url with challenge id 34 and phase id say 1 then it won't give error if phase id 1 exists(for any other challenge).

Ideally, it this url should only accept the phase ids 120 and 121 and should throw error for every other phase id.

Deliverables:
Modify the challenge phase query here to include the challenge parameter in it.

What should be added:
challenge_phase = ChallengePhase.objects.get(challenge=challenge, pk=pk)
Also, Update the response message to
response_data = {'error': 'Challenge Phase {} does not exist'.format(pk)}

GSOC-2019 backend bug easy_to_fix good first issue priority-high

Source

RishabhJain2018

All 14 comments

@RishabhJain2018 I would like to work up on this!

HargovindArora on 5 Jul 2018

👍1

Sure @HargovindArora go ahead!

RishabhJain2018 on 5 Jul 2018

@RishabhJain2018 How to check whether the changes made are showing effect? I meant how should I reproduce error after making the required changes? I tried deleting the phases of the challenges already present there, nothing happened.

HargovindArora on 6 Jul 2018

@HargovindArora I have updated the description.

RishabhJain2018 on 6 Jul 2018

I would like to start contributing by working on this !!