Evalai: Frontend (angular-ui-router): State change events are deprecated

[spyshiv]

Issue:
In angular-ui-router<=1.x, State change events are deprecated, DISABLED and replaced by Transition Hooks. So redirection and state change will not work if lnstalled version of angular-ui-router is >=1.x.
More info

How to Fix:

• change bower dependencies "angular-ui-router": "^0.3.1" to "angular-ui-router": "0.3.1" (without ^) so that installation will be restricted to version 0.3.1
  or
• if we need to go with latest version of angular-ui-router then we have to replace $rootScope.$on('$stateChangeStart', function(){ ... }) with $transitions.onStart({...}) and also have to update bower dependency for the same.

@aka-jain @RishabhJain2018 @deshraj

[xamfy]

I want to do this, should I just update the dependencies?

[RishabhJain2018]

@xamfy I think you are currently working on #1247 . Please complete that first then you can take this up as it blocks the development of the whole project. Till then it is open for everyone. :)

[Ayukha]

Can i try ? @RishabhJain2018

[RishabhJain2018]

@Ayukha Yes you can. Assigning this to you.

[RishabhJain2018]

@spyshiv @deshraj @aka-jain I would prefer to go with the second approach of @spyshiv as in future many dependency conflicts can be avoided by using the latest version of angular-ui-router. What do you say?

[spyshiv]

second approach 👍

[sblcook]

I can give the second one a shot if @Ayukha isn't working on it. I only found three uses of the old method when I searched.

[aka-jain]

Second approach doesn't seem like a good option for now as we are using state related functions heavily in project and updation of ui router might break any functionality. We can only continue with the second approach once we are confident with the change.
Let's stick to the same version or first list all the functions that has been depricated in current version of UI ROUTER.
Thoughts @RishabhJain2018 @spyshiv ?

[aayusharora]

Not sure @spyshiv @aka-jain If we are planning long-term goals here, removing ^ is the solution for temporary purposes, I am in doubt that we need to maintain different packages like them too and have to restrict ourselves to the old AngularJS.

[aka-jain]

I also agree to go with the new version but first we have to be confident about all the changes that have been made to new update.
I've already tried out the latest version of UI router and there are lots of changes. We should only continue with the new version when all the changes and usage get listed down otherwise chances of code breakage will become high.

Let's do a small POC on this and will check wether all functionalities work fine or not with the new update. Till then let's stick to the older version.
@aayusharora

[aayusharora]

Agree @aka-jain, which UI router version have you tried ?

[spyshiv]

@aka-jain @RishabhJain2018 I am assigning this to me.

[spyshiv]

@Obtin : Sure!! Go ahead.
Let me know if you face any issue or need any guidance regarding this.

[spyshiv]

You're right. Second approach.

[deshraj]

Closing this since we don't need this issue now. Same reason: we will release Cloud-CV/EvalAI-Ngx soon :)