Evalai: Use IsChallengeCreator decorator in Challenge Phase detail API Endpoint
Currently, the check for if the requesting user is Creator of Challenge or not is missing from the challenge_phase_detail API View. We would like to add the IsChallengeCreator decorator (https://github.com/Cloud-CV/EvalAI/blob/master/apps/challenges/permissions.py#L6) to this endpoint.
Also, please add test cases after making the above changes.
deshraj
All 21 comments
@AnshulBasia Sure. :)
deshraj
on 29 Mar 2017
@deshraj can you tell me what exactly do we do after the check?
Shashi456
on 29 Mar 2017
@Shashi456 I think @AnshulBasia is already working on this. Feel free to pick any other unassigned issue. :)
deshraj
on 29 Mar 2017
@deshraj what about #863
Shashi456
on 29 Mar 2017
@AnshulBasia any updates on this? If you're busy, I can take it forward.
varunagrawal
on 5 Apr 2017
@varunagrawal Sorry,I am done but testing is yet to be done. I got stuck with my assignments. Please take it forward. Thanks.
AnshulBasia
on 6 Apr 2017
Sure thing mate @AnshulBasia. Thanks for letting us know. :)
varunagrawal
on 7 Apr 2017
@deshraj please assign this to me.
varunagrawal
on 25 Apr 2017
Sure.
deshraj
on 26 Apr 2017
@deshraj Can you please tell me what we need to do exactly.
modestlearner
on 11 Sep 2017
@modestlearner: This is quite critical and I would like to fix it myself. Can you please pick some other issue?
deshraj
on 12 Sep 2017
@deshraj Sure
modestlearner
on 12 Sep 2017
@deshraj Is this solved?
guyandtheworld
on 9 Jan 2018
Hi @isht3, @deshraj has been on vacation the past few weeks and should be back today. Expect this to be solved sometime this week. :)
varunagrawal
on 9 Jan 2018
@varunagrawal Hope he had a good time, I'm going on vacation today! lol.
guyandtheworld
on 10 Jan 2018
@isht3: no, this issue is not solved yet. Please feel free to take this up.
deshraj
on 12 Jan 2018
@isht3 Deshraj has given you the go ahead. If you don't have the time to work on this, we understand, and we can assign this to @Obtin
varunagrawal
on 19 Jan 2018
@varunagrawal, @Obtin Yes, I already started working on this. I was going through how to work on decorators, that's why this was taking time. I'll finish this by sometime next week. :smile:
guyandtheworld
on 20 Jan 2018
@deshraj The IsChallengeCreator Class in permissions.py and its use-cases should be completely replaced with the IsChallengeCreator decorator, yes?
guyandtheworld
on 28 Jan 2018
@isht3 no that class is required in the permissions since other API endpoints depend on it. You should just be able to add that permission class to the @permission_classes decorator and have it work. The crucial aspect of this issue are the test cases which need to ensure all corner cases are handled.
I know this seems like very little work technically, but then again, this is an easy issue to get people started with CloudCV contribution. :)
varunagrawal
on 29 Jan 2018
@varunagrawal I think the changes are already added to the permission_classes, I'll get started with writing the tests. Thank you for clearing it up!
guyandtheworld
on 29 Jan 2018
Related issues
vivektalwar13071999
路
3Comments
Arun-Jain
路
6Comments
Ayukha
路
5Comments
HargovindArora
路
4Comments
Ayukha
路
5Comments
Most helpful comment
@varunagrawal, @Obtin Yes, I already started working on this. I was going through how to work on decorators, that's why this was taking time. I'll finish this by sometime next week. :smile: