@spyshiv assigning it to you.
Cool..
@spyshiv you working on this ? can I try ?
Yes. I am working on this. Will update it soon.
Thank you for reminding me.
@RishabhJain2018 : Do you want to work on this issue? Let me know if you are interested.
@spyshiv yeah sure.
I am assuming that you are familiar with the tasks lint and watch. So what you have to do is whenever any js file is changed you have to make run gulp lint.
Let me know if you stuck somewhere.
@RishabhJain2018 Just going through your PR, yes the code is right but we have to do some additional changes too. Like server should not run until you solve all the errors of lint. So integrate lint with watch such that if we get any error than server should stop. Getting?
@spyshiv want to add something else?
@aka-jain Yeah I got this point. :+1: @spyshiv Please tell anything else that should be added ? I will update the PR accordingly.
@aka-jain @spyshiv Please reopen this issue as some task is still left on this issue . Please refer to above conversation.
I didn't close this issue intentionally it is done automatically. :smile:
Reopening again.
@aka-jain @RishabhJain2018 : For the reference please have a look at comment in gulpfile.js line 233.
PS: Since it should not be a blocker so once the linting errors and warnings are fixed (issue #805) then start doing work on this.
@aka-jain @spyshiv By this So integrate lint with watch such that if we get any error than server should stop, you want to say that gulp watch task should break when any lint error is present or server should not start until all lint errors are solved ??
@RishabhJain2018
Keep 'gulp watch' always active.
Order of running tasks
1. Watch 2. Lint 3. Connect
- Watch should always be running
- If Lint gives an error then break the connect (should stop the server)
- If Lint is fine then run connect
Getting??
Let me know if you have any doubt.
@spyshiv Okay sure.
@RishabhJain2018 : lint errors are removed. Now you can start work on this issue with additional feature as discussed above.
@spyshiv okay sure.