Evalai: Wrong message coming on Signup Page.

[aka-jain]

Follow these steps:

1. login with wrong crdentials.
2. Then move to signup page.
   then there is a message at bottom of Signup form saying "Unable to log in with provided credentials."

Need to remove or empty that msg variable.

[aka-jain]

Sure, assigning it to you @anweshknayak .

[anweshknayak]

Oops I can't test it.(blank screen) I forgot. I have to search through the code.

[aka-jain]

@anweshknayak Does the error persists at client side or backened side. If it is client then can you please share the snapshot of console?

[spyshiv]

@aka-jain : We need to refresh controller on route change. Since both signup and login share same controller (AuthCtrl) and same variables (vm.isFormError, vm.FormError) that's why this is happening.

[aka-jain]

@spyshiv Or we can make that msg variable empty on clicking signup tab. Thoughts?

[spyshiv]

:+1: that's better solution since this issue is not related to ng-messages.
@anweshknayak : Do it as @aka-jain suggested. (Resetting the variables)

[yadavankit]

am emptying the auth.FormError var on ng-click SignUp in signup.html, I guess this should do the trick, but no change in signup.html is being reflected on browser. Am I missing something? @aka-jain

[aka-jain]

@yadavankit Can you put up a PR for this?

[anweshknayak]

#592 @aka-jain There were some issue I guess

[aka-jain]

I have already mentioned that we have to do some changes. And I was in doudt regarding your code as some enhancement to quality needs to be done. That's why I closed that PR.

[yadavankit]

@aka-jain yeah sure 👍

[yadavankit]

633 @aka-jain

[anweshknayak]

@yadavankit make sure if anyone has been assigned beforehand before picking up the issue. Effort goes into waste of either one.

[aka-jain]

Fixed with #636

[anweshknayak]

@aka-jain error still persists.
Go to : Login .
Next Click below : SignUp
Form error shows up.

Please check the PR. #663

[yadavankit]

@anweshknayak nice catch...since am reseting the form on ng-click of SignUp Tab, just give me a sec, will apply auth.resetForm() on SignUp link.

[anweshknayak]

@yadavankit there's no need. a functionality has been added in #632 which will do.

[yadavankit]

@anweshknayak cool 👍