Evalai: Frontend: Add validation before sending invite to other team members

[spyshiv]

• [ ] Handle errors (email required & email valid ) with ng-messages as it is done in auth pages.
• [x] Show notification on invitation success after closing the modal of email invite (depend on issue #482 )

[anweshknayak]

@spyshiv shall I try the first one ? I just made a PR which used ng-messages. And Handle errors (email required & email valid ) for which views ?

[spyshiv]

I have reviewed your PR #593 . First complete the changes then ask for this.
Till then this is issue is open for all.

[anweshknayak]

@spyshiv this is to be done for verify-email view right ?

[RishabhJain2018]

@spyshiv @aka-jain Can I work on this?

[spyshiv]

sure @RishabhJain2018, Assigning it to you.

[spyshiv]

@anweshknayak : it is regarding email invitation on dashboard.

[deshraj]

@RishabhJain2018 any update on this. This one is easier and should have been fixed by now.

[RishabhJain2018]

@deshraj Actually last week, I was busy with some of my college work.I am really sorry for the delay. I will fix this asap.

[spyshiv]

@RishabhJain2018 : What is the current status regarding this issue?

[RishabhJain2018]

@spyshiv As discussed with you, I will fix this asap.

[anweshknayak]

@spyshiv @RishabhJain2018 can I try ?

[deshraj]

Sure @anweshknayak.

[anweshknayak]

@spyshiv let me know when the notification thing is ready :)

[spyshiv]

@anweshknayak : Have you done first task which is not dependent on notification things ?
and Notification feature has been added in PR #684.
You can start working on first task. I will let you know when the PR #684 will be merged

[anweshknayak]

sure @spyshiv. And yes I will complete the first task.

[spyshiv]

@anweshknayak: I have already completed 2nd task. 3rd task is not required now so i have removed that. So finally you have to do only first task. Ask me for code review when you are done

[anweshknayak]

@spyshiv need some help. How do I get to this view? I need to test.

[spyshiv]

@anweshknayak: Sorry I was busy.

The issue is related to make this email input required. Let me know if you can/can't get this view.

[anweshknayak]

@spyshiv do I need to create separate template for mdDialog to integrate ng-messages with it ?

[aka-jain]

@anweshknayak Are you working on any other issue too?

[spyshiv]

@anweshknayak : what is the status of this issue. If you are too busy in doing other issues then let me know so that I can assign this to someone else

[anweshknayak]

@spyshiv I won't be able to work on issues for a few days. Please assign to someone else. :)

[taranjeet]

@RishabhJain2018 : can you take this up ?

[RishabhJain2018]

@TroJan Yeah sure. Currently I am on #850 . I will take this up asap.

[deshraj]

I think you have few issues on your plate. You can work on this once you complete the other issues assigned to you. :)

[deshraj]

FYI: This issue is still open. Please feel free to pick it up. Also, tagged it as a good first issue. :)

[gautamjajoo]

@deshraj Can I work on this issue?

[deshraj]

Sure, go ahead.

[gautamjajoo]

@deshraj Hey! I have done with email required. How should I proceed for checking if email is valid?

[gautamjajoo]

@deshraj @RishabhJain2018 I think you missed the above message. Also, do I have to do the same implementation as in done in https://github.com/Cloud-CV/EvalAI/pull/1542 by creating a separate invite-template.html.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed as there is no further activity. Thank you for your contributions.