Evalai: Create a custom 500 and 404 error page in for django

Created on 23 Dec 2016  路  26Comments  路  Source: Cloud-CV/EvalAI

GSOC-2019 backend easy_to_fix enhancement

All 26 comments

@deshraj Im working on this.

Sure, go ahead. Please ask before working on any issue otherwise it would be a duplicate effort.

@deshraj sure :)

@deshraj this custom error page for every app?

No, there will be a single 404 and 500 error page. Please see the reference link that I shared.

@deshraj Is someone still working on this issue??

Yes. Code is almost done. Tests needs to be added

@RishabhJain2018 let me know if you can help with the tests. you can see the closed PR. @deshraj can we split this ?

Yeah sure. That sounds like a collaborative effort. :-)

@anweshknayak yeah sure, I will help you with the tests. :+1:

@aka-jain #290 related to this ?

No @anweshnayak , It's on backend side.

@deshraj For adding tests, Can I create a file on this path tests/unit/evalai/test_urls.py.

@deshraj I think we should also remove this url from evalai/urls.py as we are not using django-allauth.

@RishabhJain2018 please use this file tests/unit/evalai/test_views.py for test or create one if does not exist.

@RishabhJain2018 We will remove the URL later. Not related to this PR. Also, we might use it somewhere in future.

@deshraj ok.

@deshraj I think we should close this issue.

Looks like this is causing issue. @jainarunarunjain is working on it. Let me know @jainarunarunjain if you want some context about the bug.

Forgot to close. Fixed now.

Reopening this since now the 404 and 500 template would be on backend and won't be dependent on the frontend. @jainarunarunjain let me know if you are interested in working on this issue. I can guide you. :-)

@deshraj Sure, I want to work on this.

Awesome. Let me know if you need any help. :-)

@deshraj please give me some details.

So, in apps/web/templates directory create two templates named 500.html and 404.html in which you can add basic html content that can be modified later. Also, you would need to create a custom 404 and 500 handler for the same as it was before.

fixed in #631

Was this page helpful?
0 / 5 - 0 ratings