Eui: [EuiSuperDatePicker] Remove static ID

Created on 17 Feb 2021  路  2Comments  路  Source: elastic/eui

EuiSuperDatePicker uses a static IDs which breaks expectations that IDs are unique.

If multiple of this same component are rendered on a page at a time (which Kibana has recently started doing), this has the potential to cause problems with assistive tech and also makes running automated tests a struggle because each instance is flagged as an issue generating a lot of noise.

It should be replaced with htmlIdGenerator

Location: https://github.com/elastic/eui/blob/master/src/components/date_picker/super_date_picker/quick_select_popover/quick_select_popover.tsx#L185

accessibility bug good first issue

All 2 comments

@myasonik Can I work on this issue?

Yup, but you don't need to ask

From our Contributing Guidelines:

In general, once on Github, any issue can be worked on by the community... If you find an issue that is not assigned, assume that you are welcome to work on it and can submit a pull request. Feel free to leave a comment to mark intent and avoid conflict.

Was this page helpful?
0 / 5 - 0 ratings