Eui: wrong height for superdatepicker button

Created on 19 Jan 2021  路  5Comments  路  Source: elastic/eui

image

code issue:
commit:
75ca1a927db9934351ebd67b97403bca9912f119
looks good with 100%- not with auto

image

https://github.com/elastic/eui/blob/75ca1a927db9934351ebd67b97403bca9912f119/src/components/form/form_control_layout/_form_control_layout.scss

!urgent! bug good first issue

All 5 comments

Hi @lior-fortifieddata,

Thanks for reporting this issue and finding the root of the problem.

In fact, the EuiSuperDatePicker prepend doesn't look good: https://elastic.github.io/eui/#/forms/super-date-picker

Screenshot 2021-01-19 at 11 42 26

Screenshot 2021-01-19 at 11 42 13

Gah! I knew there would be something somewhere that would break because of #4410 ... I just forgot to look at this one. Most likely need to get a fix ASAP

Hi, I just saw this issue 馃槦. Extremely sorry for the trouble it may have caused.

No worries @Dishebh ! We'll get it fixed. I should have listened to my conscience and done a better vetting of the change. But we're just going to revert the blanket change and make one specific to the EuiComboBox so it doesn't affect all usages of prepend/append

I'm closing this issue because it was fixed with #4432. I reopened the #4407.

Was this page helpful?
0 / 5 - 0 ratings