Eui: [EuiDatePicker] Unable to see difference between selected/disabled times when using `showTimeSelectOnly`

Created on 3 Nov 2020  路  10Comments  路  Source: elastic/eui

Demo showing the issue.

Current design

Which of these are selectable? You can't tell until hovering, but all after 5:30pm are disabled.

Image 2020-11-03 at 7 37 23 AM

Desired design

Something like:

Image 2020-11-03 at 7 38 16 AM

anyone bug good first issue

All 10 comments

Hi @smhutch @cchaos, has the issue been resolved? Somehow, I'm not able to replicate the issue.

Hi @Dishebh. Thanks for taking a look into it.

This demo shows the issue (the issue is shown in the top example, and a "fixed" design is shown below it).

@smhutch I am working on this.

This is working fine I think this is not an issue now I am not able to replicate this. @smhutch

Thanks for taking a look @git-anurag-hub. I can still see the issue in the demo. To clarify, the issue is only shown in the first date picker shown. The second date picker shows a proposed solution.

@smhutch got the problem the problem lies inside this showTimeSelectOnly when this is enabled doesn't do right thing.

Screenshot 2021-02-15 at 7 09 56 PM

@smhutch Is this good?

@git-anurag-hub that looks good to me. Thanks! 馃憤

It might be worth confirming with @cchaos or @thompsongl to confirm they are happy with this approach.

Can I open the pr? @smhutch

Closed by #4524

Was this page helpful?
0 / 5 - 0 ratings