All 14 comments
Can I give it a try?
Marvin9
on 28 Mar 2020
@myasonik react-docgen plugin is not generating __docgenInfo property of EuiIcon, After debugging custom plugin proptypes-from-ts-props and react-docgen, I found this error (in react-docgen) is stopping __docgenInfo generation.
I wonder if anything is missed out in proptypes-from-ts-props plugin or It is issue of react-docgen itself.
Marvin9
on 28 Mar 2020
@Marvin9 Are you trying it still or should I try to fix?
walter-ind
on 28 Mar 2020
You can try @walter-ind
Marvin9
on 28 Mar 2020
Thanks @Marvin9
walter-ind
on 28 Mar 2020
Figured out, if we manually remove if statement which is throwing error, we got result.
In short, the problem is with dynamic import which is not recognized by ast-types.
This issue will be solved in #3056
Marvin9
on 29 Mar 2020
There is one more way by which this issue can be fixed right now and that is if we add props_info.js file in icons folder of views directory and put all prop info into it. @myasonik ?
walter-ind
on 30 Mar 2020
EUI team, what do y'all think? I've got no idea.
myasonik
on 30 Mar 2020
There is one more way by which this issue can be fixed
right nowand that is if we add props_info.js file in icons folder of views directory and put all prop info into it. @myasonik ?
This is fine as a short term solution. If you make this, I'd advise against listing the entire icon list (since it is fairly long) for the type and make a custom output that says "Check docs for a list of acceptable values"...etc.
snide
on 30 Mar 2020
I know it would be too long. It's better to make one solution that stays for long. So better, let it be fixed by #3056.
walter-ind
on 30 Mar 2020
The icon props display for me, locally. Is this something that has already been fixed on master, or is it a problem with the docs' production build?
chandlerprall
on 31 Mar 2020
@chandlerprall I think it's a problem is in the doc's production build. I can see the icons props locally but in a build, it doesn't show up: https://eui.elastic.co/pr_3200/#/display/icons
miukimiu
on 31 Mar 2020
I just did a docs build locally (yarn build-docs && cd docs && python -m SimpleHTTPServer) and see the icon props. Let's keep an eye on this after the next EUI release & docs deploy.
chandlerprall
on 31 Mar 2020
Latest release cleared up this issue. Will monitor the builds the next few docs syncs to see if there is something flakey here.
snide
on 2 Apr 2020
Related issues
flash1293
路
3Comments
wylieconlon
路
3Comments
cchaos
路
3Comments
cedeber
路
4Comments
jen-huang
路
4Comments
Most helpful comment
Figured out, if we manually remove if statement which is throwing error, we got result.
In short, the problem is with dynamic import which is not recognized by ast-types.
This issue will be solved in #3056