Eui: [Docs] Add automated tests for all pages

Created on 17 Dec 2019  路  8Comments  路  Source: elastic/eui

After #2569, the guideline pages could manually be added to run through axe to check for accessibility issues. After #3502, all guidelines pages were tested by default unless they were disabled.

Implementation note: To see the currently skipped pages, go to scripts/a11y-testing.js.

Pages left to enable:

  • [ ] Resizable Container
  • [ ] Button
  • [ ] Tree View
  • [ ] Side Nav
  • [ ] Tables
  • [ ] In Memory Tables
  • [ ] Aspect Ratio
  • [ ] Code
  • [ ] Drag And Drop
  • [ ] Compressed Forms
  • [ ] Combo Box
  • [ ] Color Selection
  • [ ] Code Editor
  • [ ] Date Picker
  • [x] Selectable (#3570)
  • [ ] Suggest
  • [ ] Super Date Picker
  • [ ] Creating Charts
  • [ ] Part to Whole Comparisons
  • [ ] CSS Utility Classes
  • [ ] Focus Trap

PRs so far:

  • #2569
  • #2995
  • #3004
  • #3035
  • #3036
  • #3077
  • #3096
  • #3097
  • #3502
accessibility good first issue meta skip-stale-check test

All 8 comments

@myasonik what needs to be done for this?

@anishagg17, PR #2995 by @ashikmeerankutty is a good example of what needs to be done. (You can find some more examples of the type of work that might need to be done in #2569 though it's a little bit muddled with some setup work that was done as well.)

As this is a big ticket if you're going to work on it please comment on which pages you are working to add. Also, please feel free to add pages non-linearly as it's all controlled by an array of which pages to check. Feel free to push any range of pages onto that array to be tested.

You can find docs on the accessibility testing setup on the wiki.

okay @myasonik

@myasonik Loading and Progress pass axe testing

Please recheck for Layout -> header

Good catch! Removed!

is anyone working on this issue i would like to. @anishagg17 @myasonik

Hi @hetanthakkar1! This issue is quite large we (mostly @anishagg17) have been merging small PRs as they are ready to be able to make steady progress over time instead of no progress for a long time and then trying to roll out a big bang change.

You can see in the description which pages are already done and you can see open PRs (such as #3077) linked in this thread as well.

We're happy to look at any PRs for pages that aren't currently in progress!

If you're worried about conflicting with work other devs might have locally on their machines but not yet pushed to a PR, feel free to shout out here what pages you are taking on so that others know not to tackle them.

Was this page helpful?
0 / 5 - 0 ratings