Eui: EuiComboBox assumes custom options will be added to options list

[cjcenizal]

Currently, there's logic that determines all options have been selected when the length of selectedOptions is equal to the length of options (combo_box.js#L300). This is fine when the combo box is consumed as in the first example in the docs, and custom options are pushed to the array of available options.

But if the consumer _doesn't_ change the list of available options then at some point the user may add enough custom options that the check referenced above erroneously evaluates to true. When this occurs, the user will incorrectly see the "You've selected all available options" message.

[winnllam]

Hi, I'd like to try this!

Edit: actually I think it's been resolved already :)

[chandlerprall]

This is still a bug, to allow reproducing in the first combo box example (https://elastic.github.io/eui/#/forms/combo-box) comment out this line: https://github.com/elastic/eui/blob/ab29a11993e2ede3c2c7b5d2e541d8cbb510589a/src-docs/src/views/combo_box/combo_box.js#L74

And then add 10 options (I left the two default selected & added 8 custom, see screenshot below)

[winnllam]

I see, I think I may have misunderstood the first time. Will take another stab at it!

[anishagg17]

I am unable to reproduce this even though I commented that line

[winnllam]

@anishagg17 It appears when you enter 8 options, but you can still add more after and the available options appear again

[anishagg17]

Okay will try that thanks

[chandlerprall]

@cchaos when the only remaining option(s) is disabled, should the combo box display the drop down normally, or should it show the no-more-options message?

[cchaos]

What you're showing is correct. It should show the disabled option.