Ethers.js: Upgrade uuid to 8.2.0 (dependency of json-wallets)

Created on 19 Jul 2020  ·  4Comments  ·  Source: ethers-io/ethers.js

https://github.com/ethers-io/ethers.js/blob/49e83b0c4dc3a307d22939223e9ee16849229b05/packages/json-wallets/package.json#L17

There is a more recent version of uuid that contains an important fix that removes references to global (which is a node-specific reference and is not available in the browser): https://github.com/uuidjs/uuid/commit/0ea33e6597e19186bf82ea76c0b0db432068bda3

ethers/json-wallets should upgrade to at least this version.

The latest version of uuid on npm at the time of ticket creation is this: 8.2.0

enhancement fixed

Most helpful comment

I had a few minutes and this seemed like a simple task to do while some things were running. :)

I've added this in v5.0.7. Let me know if there are any issues.

All 4 comments

I've actually been meaning to remove that dependency entirely, as such a tiny amount of RFC-4122 is actually used.

I'll get this change made this week.

I had a few minutes and this seemed like a simple task to do while some things were running. :)

I've added this in v5.0.7. Let me know if there are any issues.

Awesome, thank you!

No problem.

Thanks for the reminder! :)

Was this page helpful?
0 / 5 - 0 ratings