Ethers.js: Events returned by WebSocketProvider inconsistent with getLogs

[bbarton]

Hi @ricmoo ,

When I receive an event via Websockets, the event.blockNumber appears in hex (but otherwise seems to work fine).

However, when I do provider.getLogs() (using normal Infura provider), the log.blockNumber is in decimal format.

My assumption has been that a log (using normal provider) and a Websocket event are the same type of object. Is that correct? Should both be returning decimal blockNumber?

Thanks!

[ricmoo]

Both should be returning a decimal. You are right, the subscribed events in the WebSocketProvider is skipping the regular wrapping for block, but logs are still wrapped properly. I’ll fix it shortly. And double check everything else is being normalized correctly. :)

[ricmoo]

Actually... I can't reproduce this and the place I thought might be left unguarded seems to wrap the call correctly. Can you include a snippet of code? Also, what backend are you using?

These seem to all work:

provider.getBlockNumber().then((b) => {
    console.log("getBlockNumber", b);
});

provider.on("block", (b) => {
    console.log("event", b);
    console.log("per event", provider.blockNumber);
});

[ricmoo]

Oh! Misread... One sec. :)

No wait... I didn't misread, please pass along a code snippet. :)

[bbarton]

I can confirm that the block numbers are returned correctly for your code snippets above.

The issue I'm encountering is when listening for events:

    // Listen for all contract events.
    wsContract.on("*", (event) => {
      console.log("New event from block: ", event.blockNumber); // Returns a hex value
    });

[ricmoo]

Found the problem. I'll publish after the CI completes. :)

[ricmoo]

This should be fixed in 5.0.0-beta.183. Try it out and let me know. :)

[bbarton]

It's working! Thank you.