Etcher: Drag and drop doesn't use the manifest information

[Shou]

When dragging and dropping a ZIP with a manifest name, the filename is used instead. Using the normal file selector dialog doesn't cause this to happen. It seems that the ZIP file is used as-is rather than the residing image—I'm not sure if this affects the actual writing but I suspect it might, which isn't good.

Screenshots of drag and drop versus through the file selector.

Edit: it also uses the compressed size rather than uncompressed.

[jviotti]

Ugh, looks like we should make sure we use the same logic in both scenarios.

[jviotti]

I think I coincidentally solved this issue while fixing drag and drop for https://github.com/resin-io/etcher/pull/1229. Do you mind pulling my latest changes from that PR and confirming that it solves the issue for you too? If so, I'll add a "Fixes" footer tag to the commit.

[lurch]

Wow, I never imagined my refactoring suggestion would lead to fixes in the drag'n'drop code too. Awesome! :-D

[jviotti]

Don't be humble, you knew that from the start! :P

[lurch]

@Shou Is this indeed resolved by #1229 ? If it is, should this PR #1232 be closed?

[Shou]

Yup. We can close this once it gets merged.

[jviotti]

I added a "Fixes" tag to the PR.