Etcd: Unable to close watch stream

[kghost]

Calling stream.WriteDone can't close watch stream.

And I found a commit here change the behaviour than also wait for the send routine. https://github.com/etcd-io/etcd/commit/c43831063411d923566f1c607933c1d721c1f5f2

Is there any way to close the watch stream from client side ?

[spzala]

@kghost is this doc helpful? - https://github.com/etcd-io/etcd/blob/master/clientv3/watch.go#L45 Thanks!

[kghost]

I'm direct access etcd via grpc using c++.I don't know how go client works. AFAIK, there are something we can improve.

1. Documents the API in the protobuf file, not go client. Not everybody use go client

2. Client can't close the steam, client need to wait until server decide to close the stream. It may not be a problem in golang, as go has gc and go routine, resources and routines can be freed afterwards. But it can cause problems in c++, it is very inconvenient to wait for server to destroy or deallocate objects.

[jingyih]

@kghost Could you try sending a cancel request [1]?

[1] https://github.com/etcd-io/etcd/blob/93ae5d2f5b75d25405b651721f06c5e808cd6465/etcdserver/etcdserverpb/rpc.proto#L718

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.