Etcd: Stabilize gRPC gateway (/v3beta)

Created on 22 Jan 2018 · 18Comments · Source: etcd-io/etcd

gRPC gateway serves /v3beta, should be ready as /v3

Reference https://github.com/coreos/etcd/issues/9064.

Not much to do here. Just trouble-shoot any issues that may come up. Or add any missing tests. And bump up endpoint to v3 before 3.4 release.

@hexfusion Do you want to work on this?

aretesting stale

Source

gyuho

Most helpful comment

We will double-check with gRPC team.

gyuho on 26 Jan 2018

👍2

All 18 comments

@gyuho I am a user of gRPC gateway and would love to see it stable /v3. Will try my best to support/improve.

hexfusion on 22 Jan 2018

👍2

@hexfusion Thanks! Reference when bumping up to /v3 (https://github.com/coreos/etcd/pull/8880).

gyuho on 22 Jan 2018

👍1

the thing i worry about is that gRPC web is probably going to release soon. it can be the "official" way to expose gRPC service in JSON format.

xiang90 on 26 Jan 2018

🎉1

@xiang90 does it make sense to make /v3 stable with grpc-gateway then look at https://github.com/grpc/grpc/issues/8682 for /v4? Replacing seems a fair bit of work :).

hexfusion on 26 Jan 2018

We will double-check with gRPC team.

gyuho on 26 Jan 2018

👍2

I got the ball rolling here a little.

hexfusion on 29 Jan 2018

@gyuho @hexfusion

this is the gRPC web issue: https://github.com/grpc/grpc/issues/8682.

It is an official gRPC support instead of the one from improbable.

xiang90 on 29 Jan 2018

I see thanks.

hexfusion on 29 Jan 2018

@xiang90 @gyuho either of you getting early access per comments in issue?

hexfusion on 29 Jan 2018

@hexfusion No, but seems like it should be out in a few weeks?

gyuho on 29 Jan 2018

I asked for early access to get a feel for how this will look.

hexfusion on 30 Jan 2018

@gyuho @xiang90
small snippet from readme re: grpc-web

The gateway that connects the client to the server uses Nginx. However, Nginx still doesn't support HTTP/2 (to backends) as of Q3/2017, and therefore the gateway can't be used as a reverse proxy (for load balancing). We have also added the gRPC-Web support to Envoy. In future, we expect gRPC-Web to be supported in language-specific Web frameworks too, such as Go, Java, Node, which will eliminate the need to deploy a gateway.

Being that it has a Nginx/Envoy dependency currently I do not see this becoming a short term alternative to grpc-gateway. A side car approach could be possible allowing maybe etcd-operator more reasonable support via Kubernetes. But still a ways off it seems for direct Go implimentation from gRPC team?

hexfusion on 1 Feb 2018

OK. It seems like gRPC-web really only focuses on the Web part for web app builders rather than the ease of use as a JSON+HTTP API? If that is the case, let us move forward with grpc-gateway.

xiang90 on 1 Feb 2018

@hexfusion @xiang90 Sounds good. People already depend on our current grpc-gateway anyway.

gyuho on 1 Feb 2018

Understood grpc-gateway /v3 ahead!

hexfusion on 1 Feb 2018

Going to start on this tonight.

hexfusion on 8 Feb 2018

@gyuho @xiang90 do we want to support /v3beta and /v3 depreciating /v3alpha or only support /v3 for 3.4?

hexfusion on 8 Feb 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.