Esy: Bring back esy add.

Created on 2 Aug 2018  Â·  4Comments  Â·  Source: esy/esy

esy add was removed in the lastest esy releases (not intentionally). We should bring it back.
Good first task.

good first issue help wanted

All 4 comments

Actually it’s not that simple to do that properly — we want to add package
but preserve installed versions as much as possible.
On Thu, 2 Aug 2018 at 06:28, Jordan W notifications@github.com wrote:

esy add was removed in the lastest esy releases (not intentionally). We
should bring it back.
Good first task.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/esy/esy/issues/328, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB3ghbxPglwkQQIKYuC16l-UNqbG_OSks5uMnHvgaJpZM4Vrkpk
.

The first iteration could be simpler though — resolve the most recent version and it with caret ^ to package.json.

It looks like the add command was removed in https://github.com/esy/esy/commit/114e77ed4c313fd2d68996e01ce709a2e0dd6483. Is the intention to re-implement the command in OCaml or to continue to use makeCommandDelegatingToJsImpl? Happy to give it a go either way.

@zploskey Yes! We should implement it in native code (esy-install.js is going away really soon). Ping me on Discord if you have any questions!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bryphe picture bryphe  Â·  7Comments

ulrikstrid picture ulrikstrid  Â·  5Comments

smorimoto picture smorimoto  Â·  3Comments

bryphe picture bryphe  Â·  6Comments

jordwalke picture jordwalke  Â·  5Comments