Essentials: Command day,night,rain,sun separated permission

Created on 31 Dec 2018  路  3Comments  路  Source: EssentialsX/Essentials

Feature request

Feature description

I would like to suggest separating permissions for /day and /night + /sun and /rain command.
Like essentials.day and essentials.night instead of essentials.time.set.

How the feature is useful

People then can't spam these command and do the sky blinking :smile:

open to PR enhancement

Most helpful comment

While I agree with sun/rain having permissions (under essentials.weather as suggested by @kennyrkun), day and night are more complicated as players could technically run /time 3892 to set the time as a number. A solution to this is to always check if the player has the permission essentials.time.<arg> where <arg> is just whatever argument they provided. This would allow server owners to enable /time day but not /time 0.

In addition, whatever permissions we add will need to have a config.yml option so that they are disabled by default, as this is breaking behaviour that not everyone will want or need.

All 3 comments

I think this is a good idea, but they should be essentials.time.day, essentials.weather.rain and such for extra clarity and organisation.

While I agree with sun/rain having permissions (under essentials.weather as suggested by @kennyrkun), day and night are more complicated as players could technically run /time 3892 to set the time as a number. A solution to this is to always check if the player has the permission essentials.time.<arg> where <arg> is just whatever argument they provided. This would allow server owners to enable /time day but not /time 0.

In addition, whatever permissions we add will need to have a config.yml option so that they are disabled by default, as this is breaking behaviour that not everyone will want or need.

In general, I'd consider this to be a more moderator/administrator level command, not something that players are normally given. This doesn't seem like it would be a problem if you trusted the people using these commands. Although extra permission nodes never hurt anyone, if they work.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SkyLicks picture SkyLicks  路  3Comments

Castiella picture Castiella  路  3Comments

TheMattVid picture TheMattVid  路  3Comments

MithrandirCraft picture MithrandirCraft  路  3Comments

fieu picture fieu  路  3Comments