Feature description
I would like to suggest separating permissions for /day and /night + /sun and /rain command.
Like essentials.day and essentials.night instead of essentials.time.set.
How the feature is useful
People then can't spam these command and do the sky blinking :smile:
I think this is a good idea, but they should be essentials.time.day, essentials.weather.rain and such for extra clarity and organisation.
While I agree with sun/rain having permissions (under essentials.weather as suggested by @kennyrkun), day and night are more complicated as players could technically run /time 3892 to set the time as a number. A solution to this is to always check if the player has the permission essentials.time.<arg> where <arg> is just whatever argument they provided. This would allow server owners to enable /time day but not /time 0.
In addition, whatever permissions we add will need to have a config.yml option so that they are disabled by default, as this is breaking behaviour that not everyone will want or need.
In general, I'd consider this to be a more moderator/administrator level command, not something that players are normally given. This doesn't seem like it would be a problem if you trusted the people using these commands. Although extra permission nodes never hurt anyone, if they work.
Most helpful comment
While I agree with
sun/rainhaving permissions (underessentials.weatheras suggested by @kennyrkun),dayandnightare more complicated as players could technically run/time 3892to set the time as a number. A solution to this is to always check if the player has the permissionessentials.time.<arg>where<arg>is just whatever argument they provided. This would allow server owners to enable/time daybut not/time 0.In addition, whatever permissions we add will need to have a
config.ymloption so that they are disabled by default, as this is breaking behaviour that not everyone will want or need.