Espeasy: IRremoteESP8266 was updated

Created on 10 Mar 2019  Â·  25Comments  Â·  Source: letscontrolit/ESPEasy

Summarize of the problem/feature request

The IRremoteESP8266 was updated to detect/send Samsung 36 bit codes (new type: Samsung36)

Expected behavior

When will ESPeasy include the new remote type?

Plugin Enhancement

Most helpful comment

@jimmys01:
a) thanks
b) loaded the binary file
tested sending a couple of the new Samsung36 commands
worked fine with my Bluray player Samsung BD-F6500 (remote control ak59-00167a)
thumbs up from me

All 25 comments

@jimmys01 is usually the one to add new pull requests for newer versions.

I need support for tcl and repeat codes too. I see irremoteesp8266 has option to set repeat but reviewing code espeasy does not
I quite don’t understand the target user. Having an average user send a hex code they have to calculate themselves (with a different code per ac) seems too challenging
The heatpumpir lib in the other hand has tackled this down it a way you have to send ac model, on/off option, temp, mode, etc.

It seems like there is also an ESPeasy plugin for that heatpump IR lib

I am quite far from my Pc now. The day after tomorrow I will be able to update the library. Code repeats are handled from the library if needed in a transparent way, I haven't came across a situation that they are needed yet. On how and if we should implement code repeats, ido not know..

Not sure if I understand the need for 'code repeats' well enough by just reading your posts.
Is it something like what's needed on Panasonic TV's to turn off the television? (you have to keep the power button pressed on the remote)
I've also seen it on some beamers and some need 2 or 3 presses with a certain interval.

Is it something like that?

maybe it is about raw2 repeat capability

Sorry not being so explicit.
Coolix needs 1 repeat on my ac in order for it to work reliable.
May be this should be done by the irremote lib de facto. but they say: send the query with 1 repeat.
So a dirty (or not so) May be to hard code a repeat for this one.
I’m working on a custom plugin also not related to ac so not a big issue for me to go on my own but sharing my experiences here.
The heatpumpir is like doing mostly the same than this “official” plugin so I don’t see any advantage in maintaining both. Beside it doesn’t support rx

you can use rules here, and remotely generate just event to trigger rules

@glmnet

Coolix needs 1 repeat on my ac in order for it to work reliable.

probably related to markszabo/IRremoteESP8266#579 and fixed. Check when the next nightly will be up

@jimmys01 thanks for commenting. I am well aware of that thread.
Please read everything carefully. Let me know if you have any question.
I'll keep watching IR TX and your commits.

@jimmys01 : When will the current version of IRremoteESP8266 be included in the nightly build?

@jimmys01 : When will the current version of IRremoteESP8266 be included in the nightly build?

TD-er is the boss he makes the nightly builds

@plin2 Usually PR's are not merged immediately, so people can have a look at the code and make some comments on it.
This often leads to some extra added commits, which thus may prevent new issues and/or better code.

mmh, ok. How can I compile an ESPeasy binary with infrared support? Is there a prepared script? Which parameters would I need to set if I compile the sketch in Arduino?

@plin2 follow this guide https://www.letscontrolit.com/wiki/index.php/Tutorial_building_and_uploading_with_platformio
later when you hit F7 make sure you write build (or upload) also normal, ir and 4m are the keywords needed (there are too many build configurations)
it works with vscode too, however I still don't know how to make it like the ino file extension.

This is a .ino for you to test with the latest IR library
ESPEasy.ino.zip

@jimmys01:
a) thanks
b) loaded the binary file
tested sending a couple of the new Samsung36 commands
worked fine with my Bluray player Samsung BD-F6500 (remote control ak59-00167a)
thumbs up from me

@glmnet

Coolix needs 1 repeat on my ac in order for it to work reliable.

There is going to be a fix for that, see IRremoteESP8266 commit 637

@jimmys01 thanks for the heads up. the fix is for Coolix but it does not address the repeat issue.

IMO repeats should be handled from the library until we find a way to transmit this commands by JSON, like {"Protocol":"PANASONIC","Bits":32,"Data":"0x100A0A1","REPEATS":"1"} (kinda like the tasmota way).
This will enable us also to do the AC model, on/off, set temperature , mode, later on when someone feels like tackiling thiscoding challange. example for AC command:
{"Protocol":"GREE","Temp":32,"Mode":"HEAT","POWER":"ON","SWING":"OFF"}

What about adding a hack:
if (IrType.equals(F("coolix2"))) Plugin_035_irSender->sendCOOLIX(IrCode, kCoolixBits, 1);

Yes sure, but this particular problem will be fixed as soon as IRremoteESP8266 commits the changes for having default 1 repeat for the coolix protocol (sendCOOLIX(IrCode) will default to sendCOOLIX(IrCode, kCoolixBits, 1)). I will also push it to the already overcrowded push i have made.
Also by adding a coolix2 there will be no documentation for this change... I believe that i should start writing a documentation anyway... But time is scarse I am afraid..

FYI, IRremoteESP8266 v2.5.6 has just been release which includes the changes/improvements mentioned.

@glmnet the pr #2435 includes the repeats. Also check the PRs at markszabo/IRremoteESP8266 because he has just added the AC abstraction functionality we where talking about, perhaps you want to take over and code that in the IR TX plugin. As I propose to be done above

 example for AC command:
{"Protocol":"GREE","Temp":32,"Mode":"HEAT","POWER":"ON","SWING":"OFF"}

Any thoughts?

@glmnet the pr #2435 includes the repeats. Also check the PRs at markszabo/IRremoteESP8266 because he has just added the AC abstraction functionality we where talking about, perhaps you want to take over and code that in the IR TX plugin. As I propose to be done above

 example for AC command:
{"Protocol":"GREE","Temp":32,"Mode":"HEAT","POWER":"ON","SWING":"OFF"}

Any thoughts?

implemented in #2490

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TD-er picture TD-er  Â·  5Comments

DittelHome picture DittelHome  Â·  5Comments

Grovkillen picture Grovkillen  Â·  6Comments

thehijjt picture thehijjt  Â·  4Comments

Barracuda09 picture Barracuda09  Â·  5Comments