Espeasy: Switch is set to dimmer upon update of FW

Created on 13 Jan 2018  Â·  7Comments  Â·  Source: letscontrolit/ESPEasy

I made a OTA and my two switch devices were set to dimmer instead of switch.

https://www.letscontrolit.com/forum/viewtopic.php?f=6&t=3933&p=22485#p22485

Fixed Bug Documentation

Most helpful comment

@TD-er this is the official place to do "upgrades": https://github.com/letscontrolit/ESPEasy/blob/v2.0/src/Misc.ino#L518

martinus used to update the buildnumber on each release, however for us now the buildnumber is 20000 for 2.0 and 20100 for mega/next v2.1.

Altough i'm not happy with that as well..so this needs some more thinking/discussing. :)

The buildnumber is also used to show the ESPEasy version number of all the nodes in the network via the custom udp protocol.

Maybe we need a 'config-version' number instead? But we already have 2 other defines for this: https://github.com/letscontrolit/ESPEasy/blob/v2.0/src/ESPEasy.ino#L156

Currently, when those are changed it triggers a full format/reset.

We wil need to review all these and come up with just 2 variables i think: Version number and config-version. If the config-version changes, the BuildFixes (rename to DoUpgrades()) should decide what happens: "Can we upgrade the config, or should we format?"

All 7 comments

That's a known issue.
It is introduced when fixing the non response on the switch.
Newly added switches will act correct and when you set and save it again, it will be fixed

Yes it works but not optimal :)

Maybe a documentation is the only thing missing if the issue is not doable code wise.

Well it is possible to change it. We have 8 bits to store the setting. So I can add a check to see if it is an invalid choice.
Normally I am all in favor of "settings transitions", warning users etc. But here the space is tight.

Well I just thought of a new feature.. will add it in a sec :)

Hero :)

Den 13 jan. 2018 13:54 skrev "Gijs Noorlander" notifications@github.com:

Well it is possible to change it. We have 8 bits to store the setting. So
I can add a check to see if it is an invalid choice.
Normally I am all in favor of "settings transitions", warning users etc.
But here the space is tight.

Well I just thought of a new feature.. will add it in a sec :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/letscontrolit/ESPEasy/issues/712#issuecomment-357433244,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZeBYrfdHkXg7As2-Nl7xO0-k2igehfeks5tKKdqgaJpZM4RdJ1l
.

@TD-er this is the official place to do "upgrades": https://github.com/letscontrolit/ESPEasy/blob/v2.0/src/Misc.ino#L518

martinus used to update the buildnumber on each release, however for us now the buildnumber is 20000 for 2.0 and 20100 for mega/next v2.1.

Altough i'm not happy with that as well..so this needs some more thinking/discussing. :)

The buildnumber is also used to show the ESPEasy version number of all the nodes in the network via the custom udp protocol.

Maybe we need a 'config-version' number instead? But we already have 2 other defines for this: https://github.com/letscontrolit/ESPEasy/blob/v2.0/src/ESPEasy.ino#L156

Currently, when those are changed it triggers a full format/reset.

We wil need to review all these and come up with just 2 variables i think: Version number and config-version. If the config-version changes, the BuildFixes (rename to DoUpgrades()) should decide what happens: "Can we upgrade the config, or should we format?"

Fixed right?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DittelHome picture DittelHome  Â·  5Comments

Barracuda09 picture Barracuda09  Â·  5Comments

Grovkillen picture Grovkillen  Â·  6Comments

thehijjt picture thehijjt  Â·  4Comments

uzi18 picture uzi18  Â·  5Comments