Esp8266_deauther: Interval for continous script run is ignored - fix inside

[tobybear]

The interval for running a script continuously via "run script.txt -c 60s" is ignored and always set to 10 seconds. This is because line 867 in SerialInterface.cpp contains an error:
if (list->size() == 3) {
It should be:
if (list->size() > 3) {

(if a time interval is given, the size of the liste will be 4, not 3)

[tobozo]

nice catch :clap:
Maybe if (list->size() == 4) would work?
Also this would need to be changed too: continueTime = getTime(list->get(4));

[spacehuhn]

😭 serial interface is such a mess. I think I'll redo it after all https://github.com/spacehuhn/esp8266_deauther/issues/846

[tobybear]

@tobozo :

Maybe if (list->size() == 4) would work?

That would be less future-proof if we would introduce more parameters for this function. ">3" is in my opinion slightly better.

Also this would need to be changed too: continueTime = getTime(list->get(4));

No, this one is correct with get(3), as that actually gets the fourth element (index starts at 0)

[spacehuhn]

For the upcoming version 3, I'm using SimpleCLI to solve this issue.