Esmvaltool: OBS ISCCP files have wrong standard_name

[valeriupredoi]

Here's a basic one - what do you do when the nc files have the wrong name? This prevents _io.load with constraint=standard_name from loading even before trying to apply any fixes? Is this something that we should fix before even entering esmvaltool? @mattiarighi any thoughts?

[mattiarighi]

In our data pool, the file is named like this: clisccp_ISCCP_L3_V1.0_199705-199705.nc, which is consistent with the settings in config-developer.yml:

obs4mips:
  input_dir:
    default: '[tier]/[dataset]'
  input_file: '[var]_[dataset]_[level]_[version]_*'

You need to use obs4mips in the recipe, not OBS, for this dataset, e.g.:

- {dataset: ISCCP,  project: obs4mips,  level: L3,  version: V1.0,  start_year: 2001,  end_year: 2003, tier: 1}

[valeriupredoi]

@mattiarighi the recipe is correct, the cube name is wrong, sorry, I meant the cube name is not the CMOR standard_name

[valeriupredoi]

therefore load with constraint=standard_name fails

[mattiarighi]

@jvegasbsc

[valeriupredoi]

the ISCCP/clisccp obs4mips need these fixes (I applied them locally and all works fine afterwards):

    cube.rename('isccp_cloud_area_fraction')
    cube.coord('cloud optical depth').rename('atmosphere_optical_thickness_due_to_cloud')
    cube.coord('atmosphere_optical_thickness_due_to_cloud').var_name = 'tau'
    cube.coord('air_pressure').var_name = 'plev'
    plevs = list(cube.coord('air_pressure').points)
    plevs.sort(reverse=True)
    cube.coord('air_pressure').points = plevs

the bugger is the first bit (the rename) can not be applied in our standard configuration since the loading is done based on the actual name constraint; the rest is just classic _fixes stuff

[jvegasbsc]

Ok. I wiil implement the fix and let you know when it's ready to test

[schlunma]

inmcm4 has a similar problem: #577

[jvegasbsc]

Thnks @schlunma. I will also look at that.

@valeriupredoi Can you attach an ncdump of the original file? By the way, I am assuming that pressure levels are ordered as supposed in the data and that is only the dimension variable who has them wrong

[mattiarighi]

Related to #606

[valeriupredoi]

oh crap, wrong Issue, I actually had a file, but not sure where it is now :cry:

[mattiarighi]

This should fixed now, @valeriupredoi ?

[valeriupredoi]

yes it do :grin:

[valeriupredoi]

for internal reference: recipe_autoassess_radiation_rms_cfMon_all.yml that works fine now. Byes!