Eslint-plugin-react: Incorrect indent error in multiline array expression

[jurcovicova]

After upgrade to 6.4.1 following code causes indent error:

const myFunction = () => (
  [
    <Tag
      {...properties}
    />,
    <Tag
      {...properties}
    />,
    <Tag
      {...properties}
    />,
  ]
)

error:

6:5   error  Expected indentation of 2 space characters but found 4    react/jsx-indent 
9:5   error  Expected indentation of 2 space characters but found 4    react/jsx-indent 

E.g. the error refers to second and third instance of the tag Tag in array.

Another case with the same problem:

              {condition && [
                  <Tag key="a" onClick={() => {
                    // some code
                  }} />,
                  <Tag key="b" onClick={() => {
                    // some code
                  }} />,
                ]
              }

error:

5:19  error  Expected indentation of 16 space characters but found 18  react/jsx-indent

E.g. the error refers to second instance of the tag Tag in array.

[ljharb]

The first case is a bug, but the second is correct - the line the starting [ is on determines the indentation for the rest. In other words, it wants:

              {condition && [
                <Tag key="a" onClick={() => {
                  // some code
                }} />,
                <Tag key="b" onClick={() => {
                  // some code
                }} />,
              ]}

[jurcovicova]

@ljharb In that case, I would expect two errors - one for line 2 and one for line 5. At least, when I donwgrade to 6.3.0 and intentionally indent it wrong, I get one error for each wrongly indented tag.

[ljharb]

Yes, good point - it is warning, but not in the right places.

[bigslycat]

I confirm.

[ljharb]

@bigslycat on 6.4.1?

[bigslycat]

@ljharb oh, sry. =) I check it now — on 6.4.1 it was fixed.

[nilsml]

I'm on version 7.5.1 and this is still an issue.