Eslint-plugin-jsx-a11y: aria-proptypes support for idlist
I have noticed the following errors on Material-UI side trying to upgrade this dependency:
The following aria seem to not be supported as expected:
aria-labelledbyaria-controlsaria-describedby
arial-query returns the type idlist. Something that is not supported in the implementation: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/src/rules/aria-proptypes.js#L32
oliviertassinari
All 4 comments
This is affecting the airbnb config as well, fwiw.
ljharb
on 3 Jul 2018
I'll get this fixed tonight.
6.2.0 update is on the way :)
jessebeach
on 3 Jul 2018
Here's the change in aria-query that is causing the errors: https://github.com/A11yance/aria-query/commit/6978637765f455e5be36dbbed1e4ff9ca9957f8b
What I don't yet understand is why none of the tests in this repo caught this. I don't want to simply update aria-query without getting a test case to fail here first so we don't have something like this happen again in the future.
jessebeach
on 4 Jul 2018
Closed in #456.
ljharb
on 6 Jul 2018
Related issues
lencioni
路
5Comments
zcs19871221
路
5Comments
theAdhocracy
路
5Comments
astorije
路
3Comments
AlmeroSteyn
路
5Comments
Most helpful comment
Here's the change in aria-query that is causing the errors: https://github.com/A11yance/aria-query/commit/6978637765f455e5be36dbbed1e4ff9ca9957f8b
What I don't yet understand is why none of the tests in this repo caught this. I don't want to simply update aria-query without getting a test case to fail here first so we don't have something like this happen again in the future.