Eslint-plugin-import: [no-unused-modules] Imports overriding reexports

[Ephem]

I noticed that no-unused-modules with unusedExports trips up on this syntax:

a.js:

export function a() {}

// The following line will wrongly error as unused:
export function aa() {}

b.js:

import { a } from './a';

export { aa } from './a';

I've tracked this down to this line in the src, which overwrites any previously detected reexports. The proposed fix is to do something like what is already being done in these lines to keep both reexported entries and imports.

I can give a shot at throwing together a PR if this looks reasonable?

[golopot]

The example is working as intended. Do you mean

- export { aa } from './b';
+ export { aa } from './a';

?

[Ephem]

Ah, yes, sorry for the typo. I updated the first post to be correct. 😄 Thanks for noticing!

[ljharb]

Yes, that seems like a good fix - the code was probably assuming that duplicate imports were always merged.

[Ephem]

Yeah, having a import and a reexport from the same file isn't a super common pattern. 😄

I have some code that works, just need to write a test and I'll send a PR within the next few days.